Making getter flow through 'copy' more general (copy can appear in any part of the call name now.

bdrodes · bdrodes · commit bd07b8a4c794 · 2025-03-10T11:34:26.000-04:00
diff --git a/cpp/ql/lib/experimental/Quantum/OpenSSL/OpenSSLAlgorithmGetter.qll b/cpp/ql/lib/experimental/Quantum/OpenSSL/OpenSSLAlgorithmGetter.qll
@@ -31,7 +31,7 @@ class CopyAndDupAlgorithmPassthroughCall extends AlgorithmPassthroughCall {
     // Assume flow in and out is asIndirectExpr or asDefinitingArgument since a pointer is assumed
     // to be involved
     // NOTE: not attempting to detect openssl specific copy/dup functions, but anything suspected to be copy/dup
-    this.getTarget().getName().toLowerCase().matches(["%_dup", "%_copy"]) and
+    this.getTarget().getName().toLowerCase().matches(["%_dup%", "%_copy%"]) and
     exists(Expr inArg, Type t |
       inArg = this.getAnArgument() and t = inArg.getUnspecifiedType().stripType()
     |

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class CopyAndDupAlgorithmPassthroughCall extends AlgorithmPassthroughCall {`
`31`	`31`	`// Assume flow in and out is asIndirectExpr or asDefinitingArgument since a pointer is assumed`
`32`	`32`	`// to be involved`
`33`	`33`	`// NOTE: not attempting to detect openssl specific copy/dup functions, but anything suspected to be copy/dup`
`34`		`- this.getTarget().getName().toLowerCase().matches(["%_dup", "%_copy"]) and`
	`34`	`+ this.getTarget().getName().toLowerCase().matches(["%_dup%", "%_copy%"]) and`
`35`	`35`	`exists(Expr inArg, Type t \|`
`36`	`36`	`inArg = this.getAnArgument() and t = inArg.getUnspecifiedType().stripType()`
`37`	`37`	`\|`