Simplify redundant sanitizer

smowton · smowton · commit bfbc1d48b781 · 2022-06-02T15:02:41.000+01:00
diff --git a/go/ql/src/experimental/CWE-321/HardcodedKeysLib.qll b/go/ql/src/experimental/CWE-321/HardcodedKeysLib.qll
@@ -237,10 +237,7 @@ module HardcodedKeys {
           )
       |
         TaintTracking::localTaint(randomValue, index) and
-        (
-          this.(DataFlow::ElementReadNode).reads(_, randomValue) or
-          any(DataFlow::ElementReadNode r).reads(this, index)
-        )
+        this.(DataFlow::ElementReadNode).reads(_, index)
       )
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -237,10 +237,7 @@ module HardcodedKeys {`
`237`	`237`	`)`
`238`	`238`	`\|`
`239`	`239`	`TaintTracking::localTaint(randomValue, index) and`
`240`		`- (`
`241`		`- this.(DataFlow::ElementReadNode).reads(_, randomValue) or`
`242`		`- any(DataFlow::ElementReadNode r).reads(this, index)`
`243`		`- )`
	`240`	`+ this.(DataFlow::ElementReadNode).reads(_, index)`
`244`	`241`	`)`
`245`	`242`	`}`
`246`	`243`	`}`