Swift: Add some test cases.

Author: geoffw0

swift/ql/test/query-tests/Security/CWE-022/testPathInjection.swift

@@ -2,7 +2,7 @@
 
 struct URL {
 	init?(string: String) {}
-
+    init(fileURLWithPath path: String, isDirectory: Bool) {}
 }
 
 class NSURL {
@@ -177,30 +177,30 @@ class SerializedDatabase {
     init(path: String, configuration: Configuration = Configuration(), defaultLabel: String, purpose: String? = nil) {}
 }
 
+// Realm
 
+class Realm {
+}
 
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+extension Realm {
+	struct Configuration {
+		init(
+			fileURL: URL? = URL(fileURLWithPath: "defaultFile", isDirectory: false),
+			inMemoryIdentifier: String? = nil,
+			syncConfiguration: Int = 0,
+			encryptionKey: Data? = nil,
+			readOnly: Bool = false,
+			schemaVersion: UInt64 = 0,
+			migrationBlock: Int = 0,
+			deleteRealmIfMigrationNeeded: Bool = false,
+			shouldCompactOnLaunch: Bool = false,
+			objectTypes: Int = 0,
+			seedFilePath: URL? = nil) { }
+
+		var fileURL: URL?
+        var seedFilePath: URL?
+	}
+}
 
 // --- tests ---
 
@@ -308,18 +308,18 @@ func test() {
     let _ = SerializedDatabase(path: remoteString, configuration: Configuration(), defaultLabel: "", purpose: nil) // $ hasPathInjection=208
     let _ = SerializedDatabase(path: "", configuration: Configuration(), defaultLabel: "", purpose: nil) // Safe
 
+    // Realm
 
+	_ = Realm.Configuration(fileURL: safeUrl) // GOOD
+	_ = Realm.Configuration(fileURL: remoteUrl) // BAD [NOT DETECTED]
+	_ = Realm.Configuration(seedFilePath: safeUrl) // GOOD
+	_ = Realm.Configuration(seedFilePath: remoteUrl) // BAD [NOT DETECTED]
 
-
-
-
-
-
-
-
-
-
-
+	var config = Realm.Configuration() // GOOD
+	config.fileURL = safeUrl // GOOD
+	config.fileURL = remoteUrl // BAD [NOT DETECTED]
+	config.seedFilePath = safeUrl // GOOD
+	config.seedFilePath = remoteUrl // BAD [NOT DETECTED]
 }
 
 func testSanitizers() {

swift/ql/test/query-tests/Security/CWE-321/misc.swift

@@ -0,0 +1,46 @@
+
+// --- stubs ---
+
+class Data {
+    init<S>(_ elements: S) {}
+}
+
+struct URL {
+    init(fileURLWithPath path: String, isDirectory: Bool) {}
+}
+
+class Realm {
+}
+
+extension Realm {
+	struct Configuration {
+		init(
+			fileURL: URL? = URL(fileURLWithPath: "defaultFile", isDirectory: false),
+			inMemoryIdentifier: String? = nil,
+			syncConfiguration: Int = 0,
+			encryptionKey: Data? = nil,
+			readOnly: Bool = false,
+			schemaVersion: UInt64 = 0,
+			migrationBlock: Int = 0,
+			deleteRealmIfMigrationNeeded: Bool = false,
+			shouldCompactOnLaunch: Bool = false,
+			objectTypes: Int = 0,
+			seedFilePath: URL? = nil) { }
+
+		var encryptionKey: Data?
+	}
+}
+
+// --- tests ---
+
+func test(myVarStr: String) {
+	let myVarKey = Data(myVarStr)
+	let myConstKey = Data("abcdef123456")
+
+	_ = Realm.Configuration(encryptionKey: myVarKey) // GOOD
+	_ = Realm.Configuration(encryptionKey: myConstKey) // BAD [NOT DETECTED]
+
+	var config = Realm.Configuration() // GOOD
+	config.encryptionKey = myVarKey // GOOD
+	config.encryptionKey = myConstKey // BAD [NOT DETECTED]
+}

swift/ql/test/query-tests/Security/CWE-321/rncryptor.swift

@@ -52,16 +52,16 @@ class RNDecryptor : RNCryptor
 
 // --- tests ---
 
-func test() {
+func test(var myVarKey: Data, var myHMACKey: Data) {
 	// RNCryptor
 	let myEncryptor = RNEncryptor()
 	let myDecryptor = RNDecryptor()
 	let myData = Data(0)
 	let myConstKey = Data("abcdef123456")
-	let myHMACKey = Data(0)
 	let myHandler = {}
 	let myIV = Data(0)
 
+	let _ = RNEncryptor(settings: kRNCryptorAES256Settings, encryptionKey: myVarKey, hmacKey: myHMACKey, handler: myHandler) // GOOD
 	let _ = RNEncryptor(settings: kRNCryptorAES256Settings, encryptionKey: myConstKey, hmacKey: myHMACKey, handler: myHandler) // BAD
 	let _ = RNEncryptor(settings: kRNCryptorAES256Settings, encryptionKey: myConstKey, HMACKey: myHMACKey, handler: myHandler) // BAD
 	let _ = RNEncryptor(settings: kRNCryptorAES256Settings, encryptionKey: myConstKey, hmacKey: myHMACKey, iv: myIV, handler: myHandler) // BAD
@@ -79,4 +79,6 @@ func test() {
 	let _ = try? myDecryptor.decryptData(myData, withEncryptionKey: myConstKey, HMACKey: myHMACKey) // BAD
 	let _ = try? myDecryptor.decryptData(myData, with: kRNCryptorAES256Settings, encryptionKey: myConstKey, hmacKey: myHMACKey) // BAD
 	let _ = try? myDecryptor.decryptData(myData, withSettings: kRNCryptorAES256Settings, encryptionKey: myConstKey, HMACKey: myHMACKey) // BAD
+
+	let _ = RNEncryptor(settings: kRNCryptorAES256Settings, encryptionKey: myVarKey, hmacKey: myConstKey, handler: myHandler) // BAD [NOT DETECTED]
 }