Merge pull request #12086 from tamasvajk/feature/fix-exception-handling-archive

tamasvajk · web-flow · commit c03fe70b8d22 · 2023-02-06T08:53:56.000+01:00
C#: Change handled exception in `TrapWriter.ArchiveContents`
diff --git a/csharp/extractor/Semmle.Extraction/TrapWriter.cs b/csharp/extractor/Semmle.Extraction/TrapWriter.cs
@@ -223,7 +223,7 @@ private void ArchiveContents(PathTransformer.ITransformedPath transformedPath, s
             {
                 FileUtils.MoveOrReplace(tmpSrcFile, dest);
             }
-            catch (IOException ex)
+            catch (Exception ex)
             {
                 // If this happened, it was probably because the same file was compiled multiple times.
                 // In any case, this is not a fatal error.

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ private void ArchiveContents(PathTransformer.ITransformedPath transformedPath, s`
`223`	`223`	`{`
`224`	`224`	`FileUtils.MoveOrReplace(tmpSrcFile, dest);`
`225`	`225`	`}`
`226`		`- catch (IOException ex)`
	`226`	`+ catch (Exception ex)`
`227`	`227`	`{`
`228`	`228`	`// If this happened, it was probably because the same file was compiled multiple times.`
`229`	`229`	`// In any case, this is not a fatal error.`