Revert "JS: Add support for " of " syntax to help during transition"

This reverts commit 9bf522b.

Author: asgerf

javascript/ql/lib/semmle/javascript/frameworks/data/internal/AccessPathSyntax.qll

@@ -52,23 +52,6 @@ class AccessPath extends string instanceof AccessPath::Range {
   AccessPathToken getLastToken(int n) { result = getToken(getNumToken() - 1 - n) }
 }
 
-/**
- * An access path that uses `A of B` syntax, which should now be written as `B.A`.
- *
- * This is a compatibility layer to help test at checkpoints during transition to the new syntax.
- */
-private class LegacyAccessPath extends AccessPath {
-  LegacyAccessPath() { this.matches("% of %") }
-
-  private string getRawSplit(int n) { result = this.splitAt(" of ", n) }
-
-  private int getNumRawSplits() { result = strictcount(int n | exists(getRawSplit(n))) }
-
-  override string getRawToken(int n) { result = getRawSplit(getNumRawSplits() - n - 1) }
-
-  override predicate hasSyntaxError() { none() }
-}
-
 /**
  * An access part token such as `Argument[1]` or `ReturnValue`, appearing in one or more access paths.
  */

javascript/ql/test/library-tests/frameworks/data/test.expected

@@ -28,7 +28,6 @@ taintFlow
 | test.js:76:31:76:38 | source() | test.js:76:31:76:38 | source() |
 | test.js:77:34:77:41 | source() | test.js:77:34:77:41 | source() |
 | test.js:81:28:81:35 | source() | test.js:81:28:81:35 | source() |
-| test.js:87:40:87:47 | source() | test.js:87:40:87:47 | source() |
 isSink
 | test.js:46:18:46:25 | source() | test-sink |
 | test.js:47:22:47:29 | source() | test-sink |
@@ -72,7 +71,6 @@ isSink
 | test.js:78:34:78:34 | 3 | test-sink |
 | test.js:81:28:81:35 | source() | test-sink |
 | test.js:82:28:82:28 | 1 | test-sink |
-| test.js:87:40:87:47 | source() | test-sink |
 syntaxErrors
 | Member[foo |
 | Member[foo] .Member[bar] |

javascript/ql/test/library-tests/frameworks/data/test.js

@@ -83,6 +83,4 @@ function testSinks() {
   testlib.mySinkIfArityTwo(source(), 2, 3); // OK
   testlib.mySinkIfArityTwo(1, source(), 3); // OK
   testlib.mySinkIfArityTwo(1, 2, source()); // OK
-
-  testlib.one.two.three().legacySyntax(source()); // NOT OK
 }

javascript/ql/test/library-tests/frameworks/data/test.ql

@@ -34,13 +34,6 @@ class Sinks extends ModelInput::SinkModelCsv {
   }
 }
 
-class LegacySyntaxTest extends ModelInput::SinkModelCsv {
-  override predicate row(string row) {
-    row =
-      "testlib;;Argument[0] of Member[legacySyntax] of ReturnValue of Member[three] of Member[two] of Member[one];test-sink"
-  }
-}
-
 class BasicTaintTracking extends TaintTracking::Configuration {
   BasicTaintTracking() { this = "BasicTaintTracking" }