File tree Expand file tree Collapse file tree
javascript/ql/src/semmle/javascript/security/dataflow Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -40,6 +40,9 @@ module InsecureDownload {
4040 */
4141 abstract class Sanitizer extends DataFlow:: Node { }
4242
43+ /**
44+ * Flow-labels for reasoning about download of sensitive file through insecure connection.
45+ */
4346 module Label {
4447 /**
4548 * A flow-label for file URLs that are both sensitive and downloaded over an insecure connection.
@@ -48,6 +51,9 @@ module InsecureDownload {
4851 SensitiveInsecureURL ( ) { this = "sensitiveInsecure" }
4952 }
5053
54+ /**
55+ * A flow-label for a URL that is downloaded over an insecure connection.
56+ */
5157 class InsecureURL extends DataFlow:: FlowLabel {
5258 InsecureURL ( ) { this = "insecure" }
5359 }
@@ -114,7 +120,7 @@ module InsecureDownload {
114120 }
115121
116122 /**
117- * Gets a node for the response from `request`, type-tracked using `t`.
123+ * Gets a node for the response from `request`, type-tracked using `t`.
118124 */
119125 DataFlow:: SourceNode clientRequestResponse ( DataFlow:: TypeTracker t , ClientRequest request ) {
120126 t .start ( ) and
@@ -132,7 +138,7 @@ module InsecureDownload {
132138
133139 FileWriteSink ( ) {
134140 this = request .getUrl ( ) and
135- clientRequestResponse ( DataFlow:: TypeTracker:: end ( ) , request ) .flowsTo ( write .getADataNode ( ) ) and
141+ clientRequestResponse ( DataFlow:: TypeTracker:: end ( ) , request ) .flowsTo ( write .getADataNode ( ) ) and
136142 hasUnsafeExtension ( write .getAPathArgument ( ) .getStringValue ( ) )
137143 }
138144
You can’t perform that action at this time.
0 commit comments