Skip to content

Commit c6caf83

Browse files
committed
Python: Move PolynomialReDoS to new dataflow API
1 parent 4c33699 commit c6caf83

2 files changed

Lines changed: 17 additions & 4 deletions

File tree

python/ql/lib/semmle/python/security/dataflow/PolynomialReDoSQuery.qll

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,11 @@ import semmle.python.dataflow.new.TaintTracking
1212
import PolynomialReDoSCustomizations::PolynomialReDoS
1313

1414
/**
15+
* DEPRECATED: Use `PolynomialReDoSFlow` module instead.
16+
*
1517
* A taint-tracking configuration for detecting "polynomial regular expression denial of service (ReDoS)" vulnerabilities.
1618
*/
17-
class Configuration extends TaintTracking::Configuration {
19+
deprecated class Configuration extends TaintTracking::Configuration {
1820
Configuration() { this = "PolynomialReDoS" }
1921

2022
override predicate isSource(DataFlow::Node source) { source instanceof Source }
@@ -27,3 +29,14 @@ class Configuration extends TaintTracking::Configuration {
2729
guard instanceof SanitizerGuard
2830
}
2931
}
32+
33+
private module PolynomialReDoSConfig implements DataFlow::ConfigSig {
34+
predicate isSource(DataFlow::Node source) { source instanceof Source }
35+
36+
predicate isSink(DataFlow::Node sink) { sink instanceof Sink }
37+
38+
predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer }
39+
}
40+
41+
/** Global taint-tracking for detecting "polynomial regular expression denial of service (ReDoS)" vulnerabilities. */
42+
module PolynomialReDoSFlow = TaintTracking::Global<PolynomialReDoSConfig>;

python/ql/src/Security/CWE-730/PolynomialReDoS.ql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@
1515

1616
import python
1717
import semmle.python.security.dataflow.PolynomialReDoSQuery
18-
import DataFlow::PathGraph
18+
import PolynomialReDoSFlow::PathGraph
1919

2020
from
21-
Configuration config, DataFlow::PathNode source, DataFlow::PathNode sink, Sink sinkNode,
21+
PolynomialReDoSFlow::PathNode source, PolynomialReDoSFlow::PathNode sink, Sink sinkNode,
2222
PolynomialBackTrackingTerm regexp
2323
where
24-
config.hasFlowPath(source, sink) and
24+
PolynomialReDoSFlow::flowPath(source, sink) and
2525
sinkNode = sink.getNode() and
2626
regexp.getRootTerm() = sinkNode.getRegExp()
2727
// not (

0 commit comments

Comments
 (0)