Skip to content

Commit c6fbbb1

Browse files
committed
Python: ObjectAPI to ValueAPI: WrongNumberArgumentsInCall: CallArgs.qll: Fixes too_*_args refs to getA*Call
1 parent 2ad0f5a commit c6fbbb1

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

python/ql/src/Expressions/CallArgs.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,14 +159,14 @@ predicate too_few_args(Call call, Value callable, int limit) {
159159
not exists(call.getStarargs()) and not exists(call.getKwargs()) and
160160
arg_count(call) < limit and
161161
exists(FunctionValue func | func = get_function_or_initializer(callable) |
162-
call = func.getACall().getNode() and limit = func.minParameters() and
162+
call = func.getAFunctionCall().getNode() and limit = func.minParameters() and
163163
/* The combination of misuse of `mox.Mox().StubOutWithMock()`
164164
* and a bug in mox's implementation of methods results in having to
165165
* pass 1 too few arguments to the mocked function.
166166
*/
167167
not (useOfMoxInModule(call.getEnclosingModule()) and func.isNormalMethod())
168168
or
169-
call = func.getACall().getNode() and limit = func.minParameters() - 1
169+
call = func.getAMethodCall().getNode() and limit = func.minParameters() - 1
170170
or
171171
callable instanceof ClassValue and
172172
call.getAFlowNode() = get_a_call(callable) and limit = func.minParameters() - 1
@@ -199,9 +199,9 @@ predicate too_many_args(Call call, Value callable, int limit) {
199199
func = get_function_or_initializer(callable) and
200200
not func.getScope().hasVarArg() and limit >= 0
201201
|
202-
call = func.getACall().getNode() and limit = func.maxParameters()
202+
call = func.getAFunctionCall().getNode() and limit = func.maxParameters()
203203
or
204-
call = func.getACall().getNode() and limit = func.maxParameters() - 1
204+
call = func.getAMethodCall().getNode() and limit = func.maxParameters() - 1
205205
or
206206
callable instanceof ClassValue and
207207
call.getAFlowNode() = get_a_call(callable) and limit = func.maxParameters() - 1

0 commit comments

Comments
 (0)