C++: AuthenticationBypass

d10c · d10c · commit c744d1eb19cd · 2025-07-11T14:42:26.000+02:00
diff --git a/cpp/ql/src/Security/CWE/CWE-290/AuthenticationBypass.ql b/cpp/ql/src/Security/CWE/CWE-290/AuthenticationBypass.ql
@@ -73,8 +73,10 @@ module Config implements DataFlow::ConfigSig {
 
   predicate isSink(DataFlow::Node sink) { isSink(sink, _) }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 84 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-290/AuthenticationBypass.ql@86:8:86:16)
+  predicate observeDiffInformedIncrementalMode() { any() }
+
+  Location getASelectedSinkLocation(DataFlow::Node sink) {
+    exists(Expr condition | result = condition.getLocation() | isSink(sink, condition))
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,10 @@ module Config implements DataFlow::ConfigSig {`
`73`	`73`
`74`	`74`	`predicate isSink(DataFlow::Node sink) { isSink(sink, _) }`
`75`	`75`
`76`		`- predicate observeDiffInformedIncrementalMode() {`
`77`		`- any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 84 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-290/AuthenticationBypass.ql@86:8:86:16)`
	`76`	`+ predicate observeDiffInformedIncrementalMode() { any() }`
	`77`	`+`
	`78`	`+ Location getASelectedSinkLocation(DataFlow::Node sink) {`
	`79`	`+ exists(Expr condition \| result = condition.getLocation() \| isSink(sink, condition))`
`78`	`80`	`}`
`79`	`81`	`}`
`80`	`82`