Python: Use ConceptsTests for ClickHouse SQL libs

This did reveal a few places where we do not detect the incoming SQL

Author: RasmusWL

python/ql/test/experimental/semmle/python/frameworks/aioch/ConceptsTest.expected

@@ -1,6 +1,3 @@
 import python
+import experimental.meta.ConceptsTest
 import experimental.semmle.python.frameworks.ClickHouseDriver
-import semmle.python.Concepts
-
-from SqlExecution s
-select s, s.getSql()

…ks/clickhouse-driver/ClickHouseDriver.ql …/python/frameworks/aioch/ConceptsTest.qlpython/ql/test/experimental/semmle/python/frameworks/clickhouse-driver/ClickHouseDriver.ql renamed to python/ql/test/experimental/semmle/python/frameworks/aioch/ConceptsTest.ql python/ql/test/experimental/semmle/python/frameworks/clickhouse-driver/ClickHouseDriver.ql renamed to python/ql/test/experimental/semmle/python/frameworks/aioch/ConceptsTest.ql

@@ -0,0 +1 @@
+semmle-extractor-options: --max-import-depth=1 --lang=3

python/ql/test/experimental/semmle/python/frameworks/aioch/options

@@ -0,0 +1,30 @@
+import aioch
+
+
+SQL = "SOME SQL"
+
+
+async def aioch_test():
+    client = aioch.Client("localhost")
+
+    await client.execute(SQL) # $ getSql=SQL
+    await client.execute(query=SQL) # $ MISSING: getSql=SQL
+
+    await client.execute_with_progress(SQL) # $ getSql=SQL
+    await client.execute_with_progress(query=SQL) # $ MISSING: getSql=SQL
+
+    await client.execute_iter(SQL) # $ getSql=SQL
+    await client.execute_iter(query=SQL) # $ MISSING: getSql=SQL
+
+
+# Using custom client (this has been seen done for the blocking version in
+# `clickhouse_driver` PyPI package)
+
+
+class MyClient(aioch.Client):
+    pass
+
+
+async def test_custom_client():
+    client = MyClient("localhost")
+    await client.execute(SQL) # $ getSql=SQL

python/ql/test/experimental/semmle/python/frameworks/aioch/sql_test.py

@@ -0,0 +1,3 @@
+import python
+import experimental.meta.ConceptsTest
+import experimental.semmle.python.frameworks.ClickHouseDriver

python/ql/test/experimental/semmle/python/frameworks/clickhouse-driver/ClickHouseDriver.expected

@@ -0,0 +1,42 @@
+import clickhouse_driver
+
+
+SQL = "SOME SQL"
+
+
+# Normal operation
+client = clickhouse_driver.client.Client("localhost")
+
+client.execute(SQL) # $ MISSING: getSql=SQL
+client.execute(query=SQL) # $ MISSING: getSql=SQL
+
+client.execute_with_progress(SQL) # $ MISSING: getSql=SQL
+client.execute_with_progress(query=SQL) # $ MISSING: getSql=SQL
+
+client.execute_iter(SQL) # $ MISSING: getSql=SQL
+client.execute_iter(query=SQL) # $ MISSING: getSql=SQL
+
+
+# commonly used alias
+client = clickhouse_driver.Client("localhost")
+client.execute(SQL) # $ getSql=SQL
+
+
+# Using PEP249 interface
+conn = clickhouse_driver.connect('clickhouse://localhost')
+cursor = conn.cursor()
+cursor.execute(SQL) # $ getSql=SQL
+
+
+# Using custom client
+#
+# examples from real world code
+# https://github.com/Altinity/clickhouse-mysql-data-reader/blob/3b1b7088751b05e5bbf45890c5949b58208c2343/clickhouse_mysql/dbclient/chclient.py#L10
+# https://github.com/Felixoid/clickhouse-plantuml/blob/d8b2ba7d164a836770ec21f5e4035dfb04c41d9c/clickhouse_plantuml/client.py#L9
+
+
+class MyClient(clickhouse_driver.Client):
+    pass
+
+
+MyClient("localhost").execute(SQL) # $ getSql=SQL

python/ql/test/experimental/semmle/python/frameworks/clickhouse-driver/ClickHouseDriver.py

@@ -0,0 +1 @@
+semmle-extractor-options: --max-import-depth=1