Merge pull request #13926 from asgerf/js/fix-cyclic-alias-extraction

JS: fix crash in case of cyclic alias

Author: asgerf

javascript/extractor/lib/typescript/src/type_table.ts

@@ -659,11 +659,16 @@ export class TypeTable {
    */
   public getSymbolId(symbol: AugmentedSymbol): number {
     if (symbol.flags & ts.SymbolFlags.Alias) {
-      symbol = this.typeChecker.getAliasedSymbol(symbol);
+      let aliasedSymbol: AugmentedSymbol = this.typeChecker.getAliasedSymbol(symbol);
+      if (aliasedSymbol.$id !== -1) { // Check if aliased symbol is on-stack
+        // Follow aliases eagerly, except in cases where this leads to cycles (for things like `import Foo = Foo.Bar`)
+        symbol = aliasedSymbol;
+      }
     }
     // We cache the symbol ID to avoid rebuilding long symbol strings.
     let id = symbol.$id;
     if (id != null) return id;
+    symbol.$id = -1; // Mark as on-stack while we are computing the ID
     let content = this.getSymbolString(symbol);
     id = this.symbolIds.get(content);
     if (id != null) {

javascript/ql/src/change-notes/2023-08-23-fix-cyclic-alias-extraction.md

@@ -0,0 +1,4 @@
+---
+category: fix
+---
+* Fixed an extractor crash that would occur in rare cases when a TypeScript file contains a self-referential namespace alias.

javascript/ql/test/library-tests/TypeScript/RegressionTests/CyclicAlias/test.d.ts

@@ -0,0 +1,5 @@
+import Foo = Foo.Bar;
+
+declare namespace Foo {
+    var Bar: {};
+}

javascript/ql/test/library-tests/TypeScript/RegressionTests/CyclicAlias/test.expected

@@ -0,0 +1 @@
+| Success |

javascript/ql/test/library-tests/TypeScript/RegressionTests/CyclicAlias/test.ql

@@ -0,0 +1,2 @@
+// Just check that extraction succeeds
+select "Success"

javascript/ql/test/library-tests/TypeScript/RegressionTests/CyclicAlias/tsconfig.json

@@ -0,0 +1,3 @@
+{
+    "include": ["."]
+}