Make objects-map-changed warning non-fatal

smowton · smowton · commit d33003390806 · 2022-05-10T14:52:10.000+01:00
diff --git a/extractor/extractor.go b/extractor/extractor.go
@@ -466,8 +466,7 @@ func extractObjectTypes(tw *trap.Writer) {
 	}
 	changed = tw.ForEachObject(emitObjectType)
 	if changed {
-		// TODO: Make this non-fatal before commiting
-		log.Fatalf("Warning: more objects were labeled while emitted object types")
+		log.Printf("Warning: more objects were labeled while emitted object types")
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -466,8 +466,7 @@ func extractObjectTypes(tw *trap.Writer) {`
`466`	`466`	`}`
`467`	`467`	`changed = tw.ForEachObject(emitObjectType)`
`468`	`468`	`if changed {`
`469`		`- // TODO: Make this non-fatal before commiting`
`470`		`- log.Fatalf("Warning: more objects were labeled while emitted object types")`
	`469`	`+ log.Printf("Warning: more objects were labeled while emitted object types")`
`471`	`470`	`}`
`472`	`471`	`}`
`473`	`472`