Skip to content

Commit d47d028

Browse files
committed
Go: InsecureRandomness
1 parent cf34854 commit d47d028

1 file changed

Lines changed: 1 addition & 9 deletions

File tree

go/ql/lib/semmle/go/security/InsecureRandomness.qll

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,15 +41,7 @@ module InsecureRandomness {
4141
}
4242

4343
predicate observeDiffInformedIncrementalMode() {
44-
any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 26 (/Users/d10c/src/semmle-code/ql/go/ql/src/Security/CWE-338/InsecureRandomness.ql@33:8:33:21), Column 5 does not select a source or sink originating from the flow call on line 26 (/Users/d10c/src/semmle-code/ql/go/ql/src/Security/CWE-338/InsecureRandomness.ql@34:75:34:90)
45-
}
46-
47-
Location getASelectedSourceLocation(DataFlow::Node source) {
48-
none() // TODO: Make sure that this source location matches the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 26 (/Users/d10c/src/semmle-code/ql/go/ql/src/Security/CWE-338/InsecureRandomness.ql@33:8:33:21), Column 5 does not select a source or sink originating from the flow call on line 26 (/Users/d10c/src/semmle-code/ql/go/ql/src/Security/CWE-338/InsecureRandomness.ql@34:75:34:90)
49-
}
50-
51-
Location getASelectedSinkLocation(DataFlow::Node sink) {
52-
none() // TODO: Make sure that this sink location matches the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 26 (/Users/d10c/src/semmle-code/ql/go/ql/src/Security/CWE-338/InsecureRandomness.ql@33:8:33:21), Column 5 does not select a source or sink originating from the flow call on line 26 (/Users/d10c/src/semmle-code/ql/go/ql/src/Security/CWE-338/InsecureRandomness.ql@34:75:34:90)
44+
none() // Can't have accurate sink location override because of secondary use of `flowPath` in select.
5345
}
5446
}
5547

0 commit comments

Comments
 (0)