C++: Fix global variable exclusion in DTT.

MathiasVP · MathiasVP · commit ee62f2a2233e · 2023-01-26T16:49:58.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DefaultTaintTrackingImpl.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DefaultTaintTrackingImpl.qll
@@ -622,6 +622,8 @@ module TaintedWithPath {
 
   private predicate isGlobalVariablePathNode(WrapPathNode n) {
     n.inner().getNode().asVariable() instanceof GlobalOrNamespaceVariable
+    or
+    n.inner().getNode().asIndirectVariable() instanceof GlobalOrNamespaceVariable
   }
 
   private predicate edgesWithoutGlobals(PathNode a, PathNode b) {

Original file line number	Diff line number	Diff line change
`@@ -622,6 +622,8 @@ module TaintedWithPath {`
`622`	`622`
`623`	`623`	`private predicate isGlobalVariablePathNode(WrapPathNode n) {`
`624`	`624`	`n.inner().getNode().asVariable() instanceof GlobalOrNamespaceVariable`
	`625`	`+ or`
	`626`	`+ n.inner().getNode().asIndirectVariable() instanceof GlobalOrNamespaceVariable`
`625`	`627`	`}`
`626`	`628`
`627`	`629`	`private predicate edgesWithoutGlobals(PathNode a, PathNode b) {`