Skip to content

Commit f1a73e3

Browse files
committed
Merge branch 'jorgectf/python/deserialization' of https://github.com/jorgectf/codeql into jorgectf/python/deserialization
2 parents c2046f1 + be42470 commit f1a73e3

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

  • python/ql/src/experimental/semmle/python/frameworks

python/ql/src/experimental/semmle/python/frameworks/XML.qll

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,9 @@ private module XML {
6969
* ```
7070
*
7171
* `this` would be `xml.sax.make_parser()`, `getAnInput()` would return `StringIO(xml_content)`
72-
* and `mayBeDangerous()` would succeed since `xml.sax.handler.feature_external_ges` is set to
73-
* `False` and so it's vulnerable.
72+
* and `mayBeDangerous()` would not hold since `xml.sax.handler.feature_external_ges` is set to
73+
* `False` and so is not vulnerable.
74+
* see https://docs.python.org/3/library/xml.sax.handler.html#xml.sax.handler.feature_external_ges
7475
*/
7576
private class XMLSaxParser extends DataFlow::CallCfgNode, XMLParser::Range {
7677
DataFlow::CallCfgNode attrCall;

0 commit comments

Comments
 (0)