proper tests with depstubber, remove Duplicates :(

Author: am0o0

go/ql/lib/semmle/go/security/FileSystemAccess.qll

@@ -139,18 +139,6 @@ class AferoSystemAccess extends FileSystemAccess::Range, DataFlow::CallNode {
       mcn.hasQualifiedName("github.com/spf13/afero",
         ["WriteReader", "SafeWriteReader", "WriteFile", "ReadFile", "ReadDir"]) and
       this = mcn.getACall()
-      or
-      mcn.hasQualifiedName("github.com/spf13/afero", "Open") and
-      this = mcn.getACall()
-    )
-    or
-    exists(DataFlow::Function mcn |
-      mcn.hasQualifiedName("github.com/spf13/afero",
-        ["WriteReader", "SafeWriteReader", "WriteFile", "ReadFile", "ReadDir"]) and
-      this = mcn.getACall()
-      or
-      mcn.hasQualifiedName("github.com/spf13/afero", "Open") and
-      this = mcn.getACall()
     )
     or
     exists(DataFlow::Method mcn |
@@ -189,9 +177,6 @@ class AferoSystemAccess extends FileSystemAccess::Range, DataFlow::CallNode {
 
   override DataFlow::Node getAPathArgument() {
     if
-      this.getTarget()
-          .hasQualifiedName("github.com/spf13/afero",
-            ["WriteReader", "SafeWriteReader", "WriteFile", "ReadFile", "ReadDir"]) or
       this.getTarget()
           .hasQualifiedName("github.com/spf13/afero",
             ["WriteReader", "SafeWriteReader", "WriteFile", "ReadFile", "ReadDir"])

go/ql/test/library-tests/semmle/go/security/FileSystemAccess/FileSystemAccess.expected

@@ -0,0 +1,26 @@
+| main.go:26:6:26:69 | call to SaveToFileWithBuffer |
+| main.go:33:14:33:76 | call to WriteFile |
+| main.go:34:16:34:45 | call to ReadFile |
+| main.go:41:14:41:49 | call to ReadFile |
+| main.go:47:14:47:47 | call to ReadFile |
+| main.go:52:14:52:49 | call to ReadFile |
+| main.go:57:14:57:52 | call to ReadFile |
+| main.go:70:14:70:35 | call to ReadFile |
+| main.go:87:10:87:41 | call to File |
+| main.go:91:10:91:72 | call to Attachment |
+| main.go:100:10:100:29 | call to SendFile |
+| main.go:105:7:105:34 | call to SaveFile |
+| main.go:106:3:106:24 | call to Attachment |
+| main.go:107:10:107:29 | call to SendFile |
+| main.go:116:7:116:45 | call to SendFile |
+| main.go:117:3:117:32 | call to SendFile |
+| main.go:118:3:118:29 | call to SendFileBytes |
+| main.go:120:7:120:62 | call to SaveMultipartFile |
+| main.go:121:3:121:43 | call to ServeFile |
+| main.go:122:3:122:55 | call to ServeFileUncompressed |
+| main.go:123:3:123:40 | call to ServeFileBytes |
+| main.go:124:3:124:52 | call to ServeFileBytesUncompressed |
+| main.go:152:3:152:18 | call to File |
+| main.go:153:3:153:47 | call to ServeFile |
+| main.go:154:3:154:53 | call to FileAttachment |
+| main.go:156:7:156:40 | call to SaveUploadedFile |