Skip to content

Commit fc27b26

Browse files
committed
JS: Remove duplicate PromiseFlowStep
1 parent 66901dc commit fc27b26

2 files changed

Lines changed: 1 addition & 18 deletions

File tree

javascript/ql/src/semmle/javascript/Promises.qll

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,6 @@
44

55
import javascript
66

7-
/**
8-
* A data flow edge from a promise reaction to the corresponding handler.
9-
*/
10-
private class PromiseFlowStep extends DataFlow::AdditionalFlowStep {
11-
PromiseDefinition p;
12-
13-
PromiseFlowStep() { this = p }
14-
15-
override predicate step(DataFlow::Node pred, DataFlow::Node succ) {
16-
pred = p.getResolveParameter().getACall().getArgument(0) and
17-
succ = p.getAResolveHandler().getParameter(0)
18-
or
19-
pred = p.getRejectParameter().getACall().getArgument(0) and
20-
succ = p.getARejectHandler().getParameter(0)
21-
}
22-
}
23-
247
/**
258
* Holds if taint propagates from `pred` to `succ` through promises.
269
*/

javascript/ql/src/semmle/javascript/StandardLibrary.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ private class ES2015PromiseDefinition extends PromiseDefinition, DataFlow::NewNo
142142
/**
143143
* A data flow edge from a promise reaction to the corresponding handler.
144144
*/
145-
private class PromiseFlowStep extends DataFlow::AdditionalFlowStep {
145+
private class PromiseFlowStep extends DataFlow::AdditionalFlowStep {
146146
PromiseDefinition p;
147147

148148
PromiseFlowStep() { this = p }

0 commit comments

Comments
 (0)