Skip to content

Commit cb6be02

Browse files
committed
Properly handle encoding and closing of the buffer
1 parent 4659b80 commit cb6be02

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

pkg/github/repository_resource.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,13 @@ func RepositoryResourceContentsHandler(getClient GetClientFn, getRawClient raw.G
187187
default:
188188
var buf bytes.Buffer
189189
base64Encoder := base64.NewEncoder(base64.RawStdEncoding, &buf)
190-
base64Encoder.Write(content)
191-
defer base64Encoder.Close()
190+
_, err := base64Encoder.Write(content)
191+
if err != nil {
192+
return nil, fmt.Errorf("failed to base64 encode content: %w", err)
193+
}
194+
if err := base64Encoder.Close(); err != nil {
195+
return nil, fmt.Errorf("failed to close base64 encoder: %w", err)
196+
}
192197

193198
return &mcp.ReadResourceResult{
194199
Contents: []*mcp.ResourceContents{

0 commit comments

Comments
 (0)