fix lint errors

Author: SamMorrowDrums

pkg/errors/error.go

@@ -85,7 +85,7 @@ func GetGitHubGraphQLErrors(ctx context.Context) ([]*GitHubGraphQLError, error)
 func NewGitHubAPIErrorToCtx(ctx context.Context, message string, resp *github.Response, err error) (context.Context, error) {
 	apiErr := newGitHubAPIError(message, resp, err)
 	if ctx != nil {
-		addGitHubAPIErrorToContext(ctx, apiErr)
+		_, _ = addGitHubAPIErrorToContext(ctx, apiErr) // Explicitly ignore error for graceful handling
 	}
 	return ctx, nil
 }
@@ -110,7 +110,7 @@ func addGitHubGraphQLErrorToContext(ctx context.Context, err *GitHubGraphQLError
 func NewGitHubAPIErrorResponse(ctx context.Context, message string, resp *github.Response, err error) *mcp.CallToolResult {
 	apiErr := newGitHubAPIError(message, resp, err)
 	if ctx != nil {
-		addGitHubAPIErrorToContext(ctx, apiErr)
+		_, _ = addGitHubAPIErrorToContext(ctx, apiErr) // Explicitly ignore error for graceful handling
 	}
 	return mcp.NewToolResultErrorFromErr(message, err)
 }
@@ -119,7 +119,7 @@ func NewGitHubAPIErrorResponse(ctx context.Context, message string, resp *github
 func NewGitHubGraphQLErrorResponse(ctx context.Context, message string, err error) *mcp.CallToolResult {
 	graphQLErr := newGitHubGraphQLError(message, err)
 	if ctx != nil {
-		addGitHubGraphQLErrorToContext(ctx, graphQLErr)
+		_, _ = addGitHubGraphQLErrorToContext(ctx, graphQLErr) // Explicitly ignore error for graceful handling
 	}
 	return mcp.NewToolResultErrorFromErr(message, err)
 }

pkg/github/actions.go

@@ -680,7 +680,7 @@ func handleFailedJobLogs(ctx context.Context, client *github.Client, owner, repo
 				"error":    err.Error(),
 			}
 			// Enable reporting of status codes and error causes
-			ghErrors.NewGitHubAPIErrorToCtx(ctx, "failed to get job logs", resp, err)
+			_, _ = ghErrors.NewGitHubAPIErrorToCtx(ctx, "failed to get job logs", resp, err) // Explicitly ignore error for graceful handling
 		}
 
 		logResults = append(logResults, jobResult)
@@ -736,11 +736,11 @@ func getJobLogData(ctx context.Context, client *github.Client, owner, repo strin
 
 	if returnContent {
 		// Download and return the actual log content
-		content, resp, err := downloadLogContent(url.String())
+		content, httpResp, err := downloadLogContent(url.String()) //nolint:bodyclose // Response body is closed in downloadLogContent, but we need to return httpResp
 		if err != nil {
 			// To keep the return value consistent wrap the response as a GitHub Response
 			ghRes := &github.Response{
-				Response: resp,
+				Response: httpResp,
 			}
 			return nil, ghRes, fmt.Errorf("failed to download log content for job %d: %w", jobID, err)
 		}

pkg/github/pullrequests_test.go

@@ -275,31 +275,17 @@ func Test_UpdatePullRequest(t *testing.T) {
 			result, err := handler(context.Background(), request)
 
 			// Verify results
-			if tc.expectError {
+			if tc.expectError || tc.expectedErrMsg != "" {
 				require.NoError(t, err)
 				require.True(t, result.IsError)
 				errorContent := getErrorResult(t, result)
-				assert.Contains(t, errorContent.Text, tc.expectedErrMsg)
-				return
-			}
-
-			require.NoError(t, err)
-
-			// Check for expected error message within the result text
-			if tc.expectedErrMsg != "" {
-				if tc.expectError {
-					require.True(t, result.IsError)
-					errorContent := getErrorResult(t, result)
-					assert.Contains(t, errorContent.Text, tc.expectedErrMsg)
-				} else {
-					// Special case: error message returned as MCP error result, not Go error
-					require.True(t, result.IsError)
-					errorContent := getErrorResult(t, result)
+				if tc.expectedErrMsg != "" {
 					assert.Contains(t, errorContent.Text, tc.expectedErrMsg)
 				}
 				return
 			}
 
+			require.NoError(t, err)
 			require.False(t, result.IsError)
 
 			// Parse the result and get the text content