Skip to content

Commit 0009114

Browse files
committed
Extract scheduleForDownload method
Before we make any changes, let's extract some of the monitor code into smaller methods. Since we have test coverage, we're able to do this quite comfortably.
1 parent 3b644fe commit 0009114

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

extensions/ql-vscode/src/remote-queries/variant-analysis-monitor.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ import * as ghApiClient from './gh-api/gh-api-client';
55

66
import { VariantAnalysis, VariantAnalysisStatus } from './shared/variant-analysis';
77
import {
8-
VariantAnalysis as VariantAnalysisApiResponse
8+
VariantAnalysis as VariantAnalysisApiResponse,
9+
VariantAnalysisScannedRepository
910
} from './gh-api/variant-analysis';
1011
import { VariantAnalysisMonitorResult } from './shared/variant-analysis-monitor-result';
1112
import { processFailureReason, processUpdatedVariantAnalysis } from './variant-analysis-processor';
@@ -78,6 +79,7 @@ export class VariantAnalysisMonitor extends DisposableObject {
7879
if (variantAnalysisSummary.scanned_repositories) {
7980
variantAnalysisSummary.scanned_repositories.forEach(scannedRepo => {
8081
if (!scannedReposDownloaded.includes(scannedRepo.repository.id) && scannedRepo.analysis_status === 'succeeded') {
82+
this.scheduleForDownload(scannedRepo, variantAnalysisSummary);
8183
void commands.executeCommand('codeQL.autoDownloadVariantAnalysisResult', scannedRepo, variantAnalysisSummary);
8284
scannedReposDownloaded.push(scannedRepo.repository.id);
8385
}
@@ -94,6 +96,13 @@ export class VariantAnalysisMonitor extends DisposableObject {
9496
return { status: 'CompletedSuccessfully', scannedReposDownloaded: scannedReposDownloaded };
9597
}
9698

99+
private scheduleForDownload(
100+
scannedRepo: VariantAnalysisScannedRepository,
101+
variantAnalysisSummary: VariantAnalysisApiResponse
102+
) {
103+
void commands.executeCommand('codeQL.autoDownloadVariantAnalysisResult', scannedRepo, variantAnalysisSummary);
104+
}
105+
97106
private async sleep(ms: number) {
98107
return new Promise(resolve => setTimeout(resolve, ms));
99108
}

0 commit comments

Comments
 (0)