Skip to content

Commit 00b6ccd

Browse files
committed
Simplify condition in useEffect
1 parent 7baad1a commit 00b6ccd

File tree

1 file changed

+4
-14
lines changed

1 file changed

+4
-14
lines changed

extensions/ql-vscode/src/view/model-editor/ModelKindDropdown.tsx

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -62,21 +62,11 @@ export const ModelKindDropdown = ({
6262
);
6363

6464
useEffect(() => {
65-
const value = modeledMethod?.kind;
65+
const value = modeledMethod?.kind ?? "";
6666

67-
if (kinds.length === 0) {
68-
if (value !== "") {
69-
onChangeKind("");
70-
}
71-
72-
return;
73-
}
74-
75-
if (value === undefined) {
76-
onChangeKind(kinds[0]);
77-
}
78-
79-
if (value !== undefined && !kinds.includes(value)) {
67+
if (kinds.length === 0 && value !== "") {
68+
onChangeKind("");
69+
} else if (kinds.length > 0 && !kinds.includes(value)) {
8070
onChangeKind(kinds[0]);
8171
}
8272
}, [modeledMethod?.kind, kinds, onChangeKind]);

0 commit comments

Comments
 (0)