Don't obfuscate assignment when we choose language

elenatanasoiu · elenatanasoiu · commit 061f347ea0fc · 2023-04-11T14:59:58.000Z
Instead of assigning this property in a method, let's make the method
return a value and assign it more visibly.
diff --git a/extensions/ql-vscode/src/skeleton-query-wizard.ts b/extensions/ql-vscode/src/skeleton-query-wizard.ts
@@ -45,7 +45,7 @@ export class SkeletonQueryWizard {
 
   public async execute() {
     // show quick pick to choose language
-    await this.chooseLanguage();
+    this.language = await this.chooseLanguage();
     if (!this.language) {
       return;
     }
@@ -112,7 +112,7 @@ export class SkeletonQueryWizard {
       maxStep: 1,
     });
 
-    this.language = await askForLanguage(this.cliServer, false);
+    return await askForLanguage(this.cliServer, false);
   }
 
   private async createQlPack() {

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ export class SkeletonQueryWizard {`
`45`	`45`
`46`	`46`	`public async execute() {`
`47`	`47`	`// show quick pick to choose language`
`48`		`- await this.chooseLanguage();`
	`48`	`+ this.language = await this.chooseLanguage();`
`49`	`49`	`if (!this.language) {`
`50`	`50`	`return;`
`51`	`51`	`}`
`@@ -112,7 +112,7 @@ export class SkeletonQueryWizard {`
`112`	`112`	`maxStep: 1,`
`113`	`113`	`});`
`114`	`114`
`115`		`- this.language = await askForLanguage(this.cliServer, false);`
	`115`	`+ return await askForLanguage(this.cliServer, false);`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`private async createQlPack() {`