Replace remote database icon

Author: norascheuch

extensions/ql-vscode/media/globe.svg

@@ -8,6 +8,7 @@ import {
   ExtensionContext,
   ProviderResult,
   Range,
+  ThemeColor,
   ThemeIcon,
   TreeDataProvider,
   TreeItem,
@@ -101,11 +102,6 @@ const SHOW_QUERY_TEXT_QUICK_EVAL_MSG = `\
 
 `;
 
-/**
- * Path to icon to display next to a successful remote run.
- */
-const REMOTE_SUCCESS_QUERY_HISTORY_ITEM_ICON = "media/globe.svg";
-
 export enum SortOrder {
   NameAsc = "NameAsc",
   NameDesc = "NameDesc",
@@ -148,19 +144,10 @@ export class HistoryTreeDataProvider
 
   private history: QueryHistoryInfo[] = [];
 
-  private remoteSuccessIconPath: string;
-
   private current: QueryHistoryInfo | undefined;
 
-  constructor(
-    extensionPath: string,
-    private readonly labelProvider: HistoryItemLabelProvider,
-  ) {
+  constructor(private readonly labelProvider: HistoryItemLabelProvider) {
     super();
-    this.remoteSuccessIconPath = join(
-      extensionPath,
-      REMOTE_SUCCESS_QUERY_HISTORY_ITEM_ICON,
-    );
   }
 
   async getTreeItem(element: QueryHistoryInfo): Promise<TreeItem> {
@@ -189,10 +176,10 @@ export class HistoryTreeDataProvider
         if (element.t === "local") {
           return new ThemeIcon("database");
         } else {
-          return this.remoteSuccessIconPath;
+          return new ThemeIcon("cloud");
         }
       case QueryStatus.Failed:
-        return new ThemeIcon("error");
+        return new ThemeIcon("error", new ThemeColor("errorForeground"));
       default:
         assertNever(element.status);
     }
@@ -402,7 +389,7 @@ export class QueryHistoryManager extends DisposableObject {
     );
 
     this.treeDataProvider = this.push(
-      new HistoryTreeDataProvider(ctx.extensionPath, this.labelProvider),
+      new HistoryTreeDataProvider(this.labelProvider),
     );
     this.treeView = this.push(
       window.createTreeView("codeQLQueryHistory", {

extensions/ql-vscode/src/query-history/query-history.ts

@@ -1652,10 +1652,7 @@ describe("query-history", () => {
       labelProvider = new HistoryItemLabelProvider({
         /**/
       } as QueryHistoryConfig);
-      historyTreeDataProvider = new HistoryTreeDataProvider(
-        vscode.Uri.file(mockExtensionLocation).fsPath,
-        labelProvider,
-      );
+      historyTreeDataProvider = new HistoryTreeDataProvider(labelProvider);
     });
 
     afterEach(() => {