Skip to content

Commit 0a304f6

Browse files
committed
Use enum for query texts
1 parent 5200871 commit 0a304f6

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

extensions/ql-vscode/src/data-extensions-editor/external-api-usage-query.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import { fetchExternalApiQueries } from "./queries";
1515
import { QueryResultType } from "../pure/new-messages";
1616
import { join } from "path";
1717
import { redactableError } from "../pure/errors";
18+
import { QueryLanguage } from "../common/query-language";
1819

1920
export type RunQueryOptions = {
2021
cliServer: Pick<CodeQLCliServer, "resolveQlpacks">;
@@ -40,7 +41,7 @@ export async function runQuery({
4041
// For a reference of what this should do in the future, see the previous implementation in
4142
// https://github.com/github/vscode-codeql/blob/089d3566ef0bc67d9b7cc66e8fd6740b31c1c0b0/extensions/ql-vscode/src/data-extensions-editor/external-api-usage-query.ts#L33-L72
4243

43-
const query = fetchExternalApiQueries[databaseItem.language];
44+
const query = fetchExternalApiQueries[databaseItem.language as QueryLanguage];
4445
if (!query) {
4546
void showAndLogExceptionWithTelemetry(
4647
redactableError`No external API usage query found for language ${databaseItem.language}`,
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { fetchExternalApisQuery as javaFetchExternalApisQuery } from "./java";
22
import { Query } from "./query";
3+
import { QueryLanguage } from "../../common/query-language";
34

4-
export const fetchExternalApiQueries: Record<string, Query> = {
5-
java: javaFetchExternalApisQuery,
5+
export const fetchExternalApiQueries: Partial<Record<QueryLanguage, Query>> = {
6+
[QueryLanguage.Java]: javaFetchExternalApisQuery,
67
};

0 commit comments

Comments
 (0)