Address review comments and fix formatting.

Author: jcreedcmu

extensions/ql-vscode/src/adapt.ts

@@ -33,7 +33,7 @@ export interface RawResultSet {
 
 function adaptKind(kind: ColumnKind): ColumnType {
   // XXX what about 'u'?
-  if (kind == 'e') {
+  if (kind === 'e') {
     return { type: 'e', primitiveType: 's', locationStyle: LocationStyle.FivePart, hasLabel: true }
   }
   else {
@@ -57,21 +57,21 @@ export function adaptSchema(schema: ResultSetSchema): AdaptedSchema {
 export function adaptValue(val: ColumnValue): ResultValue {
   // XXX taking a lot of incorrect shortcuts here
 
-  if (typeof val == 'string') {
+  if (typeof val === 'string') {
     return val;
   }
 
-  if (typeof val == 'number' || typeof val == 'boolean') {
+  if (typeof val === 'number' || typeof val === 'boolean') {
     return val + '';
   }
 
   const url = val.url;
 
-  if (typeof url == 'string') {
+  if (typeof url === 'string') {
     return url;
   }
 
-  if (url == undefined) {
+  if (url === undefined) {
     return 'none';
   }
 

extensions/ql-vscode/src/interface.ts

@@ -367,7 +367,9 @@ export class InterfaceManager extends DisposableObject {
 
     if (EXPERIMENTAL_BQRS_SETTING.getValue()) {
       resultSets = [];
-      const pageSize = 100;
+      // Setting pageSize very large for now for the sake of
+      // performance testing of vscode on containers.
+      const pageSize = 1e20;
       const schemas = await this.cliServer.bqrsInfo(results.query.resultsPaths.resultsPath, pageSize);
       for (const schema of schemas["result-sets"]) {
         const chunk = await this.cliServer.bqrsDecode(results.query.resultsPaths.resultsPath, schema.name, pageSize, 0)

extensions/ql-vscode/src/view/results.tsx

@@ -45,9 +45,7 @@ async function* getChunkIterator(response: Response): AsyncIterableIterator<Uint
   }
 }
 
-function translatePrimitiveValue(value: PrimitiveColumnValue, type: PrimitiveTypeKind):
-  ResultValue {
-
+function translatePrimitiveValue(value: PrimitiveColumnValue, type: PrimitiveTypeKind): ResultValue {
   switch (type) {
     case 'i':
     case 'f':