Remove places where we are checking if credentials are undefined

This cannot happen already, even before the other changes in this PR.
The Credentials.initialize method can never return undefined, so these
checks would never return true. The real place that checks that we are
authenticated is in the vscode.authentication.getSession method, and
it will reject the promise if the user declines to authenticate or
anything else means we can't get an authenticated session.

I feel justified in removing the tests for these cases because the
code was never actually called in production, and we are covered by the
vscode authentication library rejecting the promise. Any exception
thrown from Credentials.initialize would behave the same as the one I'm
deleting.

Author: robertbrignull

extensions/ql-vscode/src/remote-queries/remote-queries-monitor.ts

@@ -27,10 +27,6 @@ export class RemoteQueriesMonitor {
   ): Promise<RemoteQueryWorkflowResult> {
     const credentials = await Credentials.initialize(this.extensionContext);
 
-    if (!credentials) {
-      throw Error("Error authenticating with GitHub");
-    }
-
     let attemptCount = 0;
 
     while (attemptCount <= RemoteQueriesMonitor.maxAttemptCount) {

extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts

@@ -480,9 +480,6 @@ export class VariantAnalysisManager
     await this.onRepoStateUpdated(variantAnalysis.id, repoState);
 
     const credentials = await Credentials.initialize(this.ctx);
-    if (!credentials) {
-      throw Error("Error authenticating with GitHub");
-    }
 
     if (cancellationToken && cancellationToken.isCancellationRequested) {
       repoState.downloadStatus =
@@ -581,9 +578,6 @@ export class VariantAnalysisManager
     }
 
     const credentials = await Credentials.initialize(this.ctx);
-    if (!credentials) {
-      throw Error("Error authenticating with GitHub");
-    }
 
     void showAndLogInformationMessage(
       "Cancelling variant analysis. This may take a while.",

extensions/ql-vscode/src/remote-queries/variant-analysis-monitor.ts

@@ -45,9 +45,6 @@ export class VariantAnalysisMonitor extends DisposableObject {
     cancellationToken: CancellationToken,
   ): Promise<void> {
     const credentials = await Credentials.initialize(this.extensionContext);
-    if (!credentials) {
-      throw Error("Error authenticating with GitHub");
-    }
 
     let attemptCount = 0;
     const scannedReposDownloaded: number[] = [];