Fix quoting of string columns in csv

Author: aeisenberg

extensions/ql-vscode/src/pure/bqrs-cli-types.ts

@@ -103,7 +103,14 @@ export function transformBqrsResultSet(
   };
 }
 
+type BqrsKind = 'String' | 'Float' | 'Integer' | 'String' | 'Boolean' | 'Date' | 'Entity';
+
+interface BqrsColumn {
+  name: string;
+  kind: BqrsKind;
+}
 export interface DecodedBqrsChunk {
   tuples: CellValue[][];
   next?: number;
+  columns: BqrsColumn[];
 }

extensions/ql-vscode/src/run-queries.ts

@@ -358,9 +358,12 @@ export class QueryEvaluationInfo {
         pageSize: 100,
         offset: nextOffset,
       });
-      for (const tuple of chunk.tuples) {
-        out.write(tuple.join(',') + '\n');
-      }
+      const quotes = chunk.columns.map(col => col.kind === 'String' ? '"' : '');
+      chunk.tuples.forEach((tuple) => {
+        out.write(tuple.map((v, i) => {
+          return `${quotes[i]}${v}${quotes[i]}`;
+        }).join(',') + '\n');
+      });
       nextOffset = chunk.next;
     }
     out.end();