Skip to content

Commit 0f5117e

Browse files
authored
Merge pull request #1828 from github/koesie10/results-loading
Add spinner when loading results
2 parents 3dd0ef5 + 51d3a01 commit 0f5117e

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

  • extensions/ql-vscode/src/view/variant-analysis

extensions/ql-vscode/src/view/variant-analysis/RepoRow.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ export const RepoRow = ({
227227
[onSelectedChange, repository],
228228
);
229229

230-
const disabled = !canExpand(status, downloadStatus);
230+
const disabled = !canExpand(status, downloadStatus) || resultsLoading;
231231
const expandableContentLoaded = isExpandableContentLoaded(
232232
status,
233233
downloadStatus,
@@ -247,11 +247,13 @@ export const RepoRow = ({
247247
checked={selected}
248248
disabled={!repository.id || !canSelect(status, downloadStatus)}
249249
/>
250-
{isExpanded ? (
250+
{isExpanded && (
251251
<ExpandCollapseCodicon name="chevron-down" label="Collapse" />
252-
) : (
252+
)}
253+
{!isExpanded && !resultsLoading && (
253254
<ExpandCollapseCodicon name="chevron-right" label="Expand" />
254255
)}
256+
{resultsLoading && <LoadingIcon label="Results are loading" />}
255257
<VSCodeBadge>
256258
{resultCount === undefined ? "-" : formatDecimal(resultCount)}
257259
</VSCodeBadge>

0 commit comments

Comments
 (0)