new repo states data type and mapping

Author: norascheuch

extensions/ql-vscode/src/variant-analysis/store/repo-states-data-types.ts

@@ -0,0 +1,7 @@
+import { VariantAnalysisScannedRepositoryDownloadStatus } from "../shared/variant-analysis";
+
+export interface VariantAnalysisScannedRepositoryStateData {
+  repositoryId: number;
+  downloadStatus: VariantAnalysisScannedRepositoryDownloadStatus;
+  downloadPercentage?: number;
+}

extensions/ql-vscode/src/variant-analysis/store/repo-states-store.ts

@@ -1,17 +1,39 @@
 import { outputJson, readJson } from "fs-extra";
 import { VariantAnalysisScannedRepositoryState } from "../shared/variant-analysis";
+import { VariantAnalysisScannedRepositoryStateData } from "./repo-states-data-types";
 
 export const REPO_STATES_FILENAME = "repo_states.json";
 
 export async function writeRepoStates(
   storagePath: string,
-  repoStates: Record<number, VariantAnalysisScannedRepositoryState> | undefined,
+  repoStates: Record<number, VariantAnalysisScannedRepositoryState>,
 ): Promise<void> {
-  return await outputJson(storagePath, repoStates);
+  // Map from repoStates Domain type to the repoStates Data type
+  const repoStatesData = Object.fromEntries(
+    Object.entries(repoStates).map(([key, value]) => {
+      const dataItem: VariantAnalysisScannedRepositoryStateData = value;
+      return [key, dataItem];
+    }),
+  );
+
+  return await outputJson(storagePath, repoStatesData);
 }
 
 export async function readRepoStates(
   storagePath: string,
 ): Promise<Record<number, VariantAnalysisScannedRepositoryState>> {
-  return await readJson(storagePath);
+  const repoStatesData: Record<
+    number,
+    VariantAnalysisScannedRepositoryStateData
+  > = await readJson(storagePath);
+
+  // Map from repoStates Data type to the repoStates Domain type
+  const repoStates = Object.fromEntries(
+    Object.entries(repoStatesData).map(([key, value]) => {
+      const dataItem: VariantAnalysisScannedRepositoryState = value;
+      return [key, dataItem];
+    }),
+  );
+
+  return repoStates;
 }

extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts

@@ -598,10 +598,13 @@ export class VariantAnalysisManager
       VariantAnalysisScannedRepositoryDownloadStatus.Succeeded;
     await this.onRepoStateUpdated(variantAnalysis.id, repoState);
 
-    await writeRepoStates(
-      this.getRepoStatesStoragePath(variantAnalysis.id),
-      this.repoStates.get(variantAnalysis.id),
-    );
+    const repoStates = this.repoStates.get(variantAnalysis.id);
+    if (repoStates) {
+      await writeRepoStates(
+        this.getRepoStatesStoragePath(variantAnalysis.id),
+        repoStates,
+      );
+    }
   }
 
   public async enqueueDownload(