Skip to content

Commit 1645363

Browse files
authored
Merge pull request #2219 from github/koesie10/fix-command-runner-references
Remove remaining references to `commandRunner`
2 parents 96c9a4a + d0c4e5b commit 1645363

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

extensions/ql-vscode/src/common/vscode/commands.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
import { telemetryListener } from "../../telemetry";
1616

1717
/**
18-
* Create a command manager for VSCode, wrapping the commandRunner
18+
* Create a command manager for VSCode, wrapping registerCommandWithErrorHandling
1919
* and vscode.executeCommand.
2020
*/
2121
export function createVSCodeCommandManager<

extensions/ql-vscode/src/extension.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ function registerErrorStubs(
236236

237237
stubbedCommands.forEach((command) => {
238238
if (excludedCommands.indexOf(command) === -1) {
239-
// This is purposefully using `commandRunner` instead of the command manager because these
239+
// This is purposefully using `registerCommandWithErrorHandling` instead of the command manager because these
240240
// commands are untyped and registered pre-activation.
241241
errorStubs.push(
242242
registerCommandWithErrorHandling(command, stubGenerator(command)),
@@ -341,7 +341,7 @@ export async function activate(
341341
),
342342
);
343343
ctx.subscriptions.push(
344-
// This is purposefully using `commandRunner` directly instead of the command manager
344+
// This is purposefully using `registerCommandWithErrorHandling` directly instead of the command manager
345345
// because this command is registered pre-activation.
346346
registerCommandWithErrorHandling(checkForUpdatesCommand, () =>
347347
installOrUpdateThenTryActivate(
@@ -1035,7 +1035,8 @@ function addUnhandledRejectionListener() {
10351035
// "uncaughtException" will trigger whenever an exception reaches the top level.
10361036
// This covers extension initialization and any code within a `setTimeout`.
10371037
// Notably this does not include exceptions thrown when executing commands,
1038-
// because `commandRunner` wraps the command body and handles errors.
1038+
// because `registerCommandWithErrorHandling` wraps the command body and
1039+
// handles errors.
10391040
process.addListener("uncaughtException", handler);
10401041

10411042
// "unhandledRejection" will trigger whenever any promise is rejected and it is

0 commit comments

Comments
 (0)