Skip to content

Commit 195cd69

Browse files
Improve variant analysis query text error messages
Co-authored-by: Robert Brignull <robertbrignull@github.com>
1 parent 268199e commit 195cd69

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

extensions/ql-vscode/src/remote-queries/variant-analysis-content-provider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ export const createVariantAnalysisContentProvider = (variantAnalysisManager: Var
1010

1111
const variantAnalysisIdString = params.get('variantAnalysisId');
1212
if (!variantAnalysisIdString) {
13-
void showAndLogWarningMessage('No variant analysis ID provided');
13+
void showAndLogWarningMessage('Unable to show query text. No variant analysis ID provided.');
1414
return undefined;
1515
}
1616
const variantAnalysisId = parseInt(variantAnalysisIdString);
1717

1818
const variantAnalysis = await variantAnalysisManager.getVariantAnalysis(variantAnalysisId);
1919
if (!variantAnalysis) {
20-
void showAndLogWarningMessage('No variant analysis found');
20+
void showAndLogWarningMessage('Unable to show query text. No variant analysis found.');
2121
return undefined;
2222
}
2323

extensions/ql-vscode/src/remote-queries/variant-analysis-view.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ export class VariantAnalysisView extends AbstractWebview<ToVariantAnalysisMessag
138138
private async openQueryText(): Promise<void> {
139139
const variantAnalysis = await this.manager.getVariantAnalysis(this.variantAnalysisId);
140140
if (!variantAnalysis) {
141-
void showAndLogWarningMessage('Could not open variant analysis query text');
141+
void showAndLogWarningMessage('Could not open variant analysis query text. Variant analysis not found.');
142142
return;
143143
}
144144

@@ -156,7 +156,7 @@ export class VariantAnalysisView extends AbstractWebview<ToVariantAnalysisMessag
156156
const doc = await workspace.openTextDocument(uri);
157157
await Window.showTextDocument(doc, { preview: false });
158158
} catch (error) {
159-
void showAndLogWarningMessage('Could not open query text');
159+
void showAndLogWarningMessage('Could not open variant analysis query text. Failed to open text document.');
160160
}
161161
}
162162
}

0 commit comments

Comments
 (0)