Skip to content

Commit 1ac92ad

Browse files
authored
Don't open variant analysis view when running a model evaluation run (#3424)
1 parent fc5d462 commit 1ac92ad

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

extensions/ql-vscode/src/model-editor/model-evaluator.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ export class ModelEvaluator extends DisposableObject {
6060
qlPack,
6161
progress,
6262
token,
63+
false,
6364
);
6465
} catch (e) {
6566
this.modelingStore.updateModelEvaluationRun(this.dbItem, undefined);

extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,7 @@ export class VariantAnalysisManager
300300
qlPackDetails: QlPackDetails,
301301
progress: ProgressCallback,
302302
token: CancellationToken,
303+
openViewAfterSubmission = true,
303304
): Promise<number | undefined> {
304305
await saveBeforeStart();
305306

@@ -399,10 +400,13 @@ export class VariantAnalysisManager
399400
`Variant analysis ${mappedVariantAnalysis.query.name} submitted for processing`,
400401
);
401402

402-
void this.app.commands.execute(
403-
"codeQL.openVariantAnalysisView",
404-
mappedVariantAnalysis.id,
405-
);
403+
if (openViewAfterSubmission) {
404+
void this.app.commands.execute(
405+
"codeQL.openVariantAnalysisView",
406+
mappedVariantAnalysis.id,
407+
);
408+
}
409+
406410
void this.app.commands.execute(
407411
"codeQL.monitorNewVariantAnalysis",
408412
mappedVariantAnalysis,

0 commit comments

Comments
 (0)