Remove glob-promise and upgrade to glob 9

The `glob` package now uses promises in version 9, so we don't need the
separate `glob-promise` package anymore.

This also updates one call site to use `cwd` instead of `join` to
avoid possible issues due to a breaking change in version 8 which treats
Windows path separators differently. By changing the `cwd`, we should
not run into these issues.

Removing the `resolutions` of `glob-parent` did not change the
`package-lock.json`, so this does not have any effect on the package
version we are using.

Author: koesie10

extensions/ql-vscode/package-lock.json

@@ -1442,7 +1442,6 @@
     "d3": "^7.6.1",
     "d3-graphviz": "^5.0.2",
     "fs-extra": "^11.1.1",
-    "glob-promise": "^6.0.2",
     "immutable": "^4.0.0",
     "js-yaml": "^4.1.0",
     "minimist": "~1.2.6",
@@ -1493,7 +1492,6 @@
     "@types/d3-graphviz": "^2.6.6",
     "@types/del": "^4.0.0",
     "@types/fs-extra": "^11.0.1",
-    "@types/glob": "^7.1.1",
     "@types/google-protobuf": "^3.2.7",
     "@types/gulp": "^4.0.9",
     "@types/gulp-replace": "^1.1.0",
@@ -1573,8 +1571,5 @@
       "prettier --write",
       "eslint --fix"
     ]
-  },
-  "resolutions": {
-    "glob-parent": "6.0.0"
   }
 }

extensions/ql-vscode/package.json

@@ -6,7 +6,7 @@ import {
   writeFile,
   opendir,
 } from "fs-extra";
-import { promise as glob } from "glob-promise";
+import { glob } from "glob";
 import { load } from "js-yaml";
 import { join, basename } from "path";
 import { dirSync } from "tmp-promise";
@@ -515,7 +515,9 @@ export async function getQlPackForDbscheme(
 export async function getPrimaryDbscheme(
   datasetFolder: string,
 ): Promise<string> {
-  const dbschemes = await glob(join(datasetFolder, "*.dbscheme"));
+  const dbschemes = await glob("*.dbscheme", {
+    cwd: datasetFolder,
+  });
 
   if (dbschemes.length < 1) {
     throw new Error(

extensions/ql-vscode/src/helpers.ts

@@ -1,5 +1,5 @@
 import { pathExists, stat, remove } from "fs-extra";
-import { promise as glob } from "glob-promise";
+import { glob } from "glob";
 import { join, basename, resolve, relative, dirname, extname } from "path";
 import * as vscode from "vscode";
 import * as cli from "./cli";