Avoid using a synchronous file system command

Add the tmp-promise package to allow for async tmp file
operations.

Author: aeisenberg

common/config/rush/pnpm-lock.yaml

@@ -612,7 +612,8 @@
     "vscode-test-adapter-util": "~0.7.0",
     "minimist": "~1.2.5",
     "semver": "~7.3.2",
-    "@types/semver": "~7.2.0"
+    "@types/semver": "~7.2.0",
+    "tmp-promise": "~3.0.2"
   },
   "devDependencies": {
     "@types/chai": "^4.1.7",

extensions/ql-vscode/package.json

@@ -1,6 +1,6 @@
 import * as fs from 'fs-extra';
 import * as yaml from 'js-yaml';
-import * as tmp from 'tmp';
+import * as tmp from 'tmp-promise';
 import * as vscode from 'vscode';
 import { decodeSourceArchiveUri, zipArchiveScheme } from './archive-filesystem-provider';
 import { ColumnKindCode, EntityValue, getResultSetSchema, LineColumnLocation, UrlValue } from './bqrs-cli-types';
@@ -42,7 +42,7 @@ function nameOfKeyType(keyType: KeyType): string {
 }
 
 async function resolveQueries(cli: CodeQLCliServer, qlpack: string, keyType: KeyType): Promise<string[]> {
-  const suiteFile = tmp.fileSync({ postfix: '.qls' }).name;
+  const suiteFile = (await tmp.file()).path;
   const suiteYaml = { qlpack, include: { kind: 'definitions', 'tags contain': tagOfKeyType(keyType) } };
   await fs.writeFile(suiteFile, yaml.safeDump(suiteYaml), 'utf8');