Skip to content

Commit 23ddc83

Browse files
Inline methods that are small and only used from one place
1 parent 54ec146 commit 23ddc83

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import { asError, assertNever, getErrorMessage } from "../common/helpers-pure";
2626
import { generateFlowModel } from "./generate-flow-model";
2727
import { promptImportGithubDatabase } from "../databases/database-fetcher";
2828
import { App } from "../common/app";
29-
import { ResolvableLocationValue } from "../common/bqrs-cli-types";
3029
import { showResolvableLocation } from "../databases/local-databases/locations";
3130
import { decodeBqrsToExternalApiUsages } from "./bqrs";
3231
import { redactableError } from "../common/errors";
@@ -233,19 +232,9 @@ export class DataExtensionsEditorView extends AbstractWebview<
233232

234233
protected async handleJumpToUsage(usage: Usage) {
235234
if (showModelDetailsView()) {
236-
await this.openModelDetailsView(usage);
235+
await this.revealItemInDetailsPanel(usage);
237236
}
238-
await this.jumpToUsage(usage.url);
239-
}
240-
241-
protected async openModelDetailsView(usage: Usage) {
242-
await this.revealItemInDetailsPanel(usage);
243-
}
244-
245-
protected async jumpToUsage(
246-
location: ResolvableLocationValue,
247-
): Promise<void> {
248-
await showResolvableLocation(location, this.databaseItem, this.app.logger);
237+
await showResolvableLocation(usage.url, this.databaseItem, this.app.logger);
249238
}
250239

251240
protected async loadExistingModeledMethods(): Promise<void> {

0 commit comments

Comments
 (0)