Add sort by date added for databases

This uses the dateAdded field on databases. It will only work for 
databases added after that field was added. Otherwise, the dateAdded
property will be undefined.

Author: aeisenberg

extensions/ql-vscode/package.json

@@ -214,6 +214,14 @@
           "dark": "media/dark/sort-alpha.svg"
         }
       },
+      {
+        "command": "codeQLDatabases.sortByDateAdded",
+        "title": "Sort by Date Added",
+        "icon": {
+          "light": "media/light/sort-date.svg",
+          "dark": "media/dark/sort-date.svg"
+        }
+      },
       {
         "command": "codeQL.checkForUpdatesToCLI",
         "title": "CodeQL: Check for CLI Updates"
@@ -270,6 +278,11 @@
           "when": "view == codeQLDatabases",
           "group": "navigation"
         },
+        {
+          "command": "codeQLDatabases.sortByDateAdded",
+          "when": "view == codeQLDatabases",
+          "group": "navigation"
+        },
         {
           "command": "codeQL.chooseDatabase",
           "when": "view == codeQLDatabases",
@@ -361,6 +374,10 @@
           "command": "codeQLDatabases.sortByName",
           "when": "false"
         },
+        {
+          "command": "codeQLDatabases.sortByDateAdded",
+          "when": "false"
+        },
         {
           "command": "codeQLDatabases.removeDatabase",
           "when": "false"

extensions/ql-vscode/src/databases-ui.ts

@@ -36,7 +36,9 @@ function joinThemableIconPath(base: string, iconPath: ThemableIconPath): Themabl
 
 enum SortOrder {
   NameAsc = 'NameAsc',
-  NameDesc = 'NameDesc'
+  NameDesc = 'NameDesc',
+  DateAddedAsc = 'DateAddedAsc',
+  DateAddedDesc = 'DateAddedDesc'
 }
 
 /**
@@ -97,6 +99,10 @@ class DatabaseTreeDataProvider extends DisposableObject
             return db1.name.localeCompare(db2.name);
           case SortOrder.NameDesc:
             return db2.name.localeCompare(db1.name);
+          case SortOrder.DateAddedAsc:
+            return (db1.dateAdded || 0) - (db2.dateAdded || 0);
+          case SortOrder.DateAddedDesc:
+            return (db2.dateAdded || 0) - (db1.dateAdded || 0);
         }
       });
     }
@@ -171,6 +177,7 @@ export class DatabaseUI extends DisposableObject {
     ctx.subscriptions.push(commands.registerCommand('codeQL.clearCache', this.handleClearCache));
     ctx.subscriptions.push(commands.registerCommand('codeQLDatabases.setCurrentDatabase', this.handleMakeCurrentDatabase));
     ctx.subscriptions.push(commands.registerCommand('codeQLDatabases.sortByName', this.handleSortByName));
+    ctx.subscriptions.push(commands.registerCommand('codeQLDatabases.sortByDateAdded', this.handleSortByDateAdded));
     ctx.subscriptions.push(commands.registerCommand('codeQLDatabases.removeDatabase', this.handleRemoveDatabase));
     ctx.subscriptions.push(commands.registerCommand('codeQLDatabases.upgradeDatabase', this.handleUpgradeDatabase));
   }
@@ -191,6 +198,14 @@ export class DatabaseUI extends DisposableObject {
     }
   }
 
+  private handleSortByDateAdded = async () => {
+    if (this.treeDataProvider.sortOrder === SortOrder.DateAddedAsc) {
+      this.treeDataProvider.sortOrder = SortOrder.DateAddedDesc;
+    } else {
+      this.treeDataProvider.sortOrder = SortOrder.DateAddedAsc;
+    }
+  }
+
   private handleUpgradeCurrentDatabase = async (): Promise<void> => {
     await this.handleUpgradeDatabase(this.databaseManager.currentDatabaseItem);
   }

extensions/ql-vscode/src/databases.ts

@@ -554,8 +554,8 @@ export class DatabaseManager extends DisposableObject {
       if (typeof state.options.ignoreSourceArchive === 'boolean') {
         ignoreSourceArchive = state.options.ignoreSourceArchive;
       }
-      if (typeof state.dateAdded === 'number') {
-        dateAdded = state.dateAdded;
+      if (typeof state.options.dateAdded === 'number') {
+        dateAdded = state.options.dateAdded;
       }
     }
     const fullOptions: FullDatabaseOptions = {