Remove statusString method

Author: koesie10

extensions/ql-vscode/src/compare/compare-view.ts

@@ -125,12 +125,12 @@ export class CompareView extends AbstractWebview<
           // only run interpolation if the label is user-defined
           // otherwise we will wind up with duplicated rows
           name: this.labelProvider.getShortLabel(from),
-          status: from.completedQuery.statusString,
+          status: from.completedQuery.message,
           time: from.startTime,
         },
         toQuery: {
           name: this.labelProvider.getShortLabel(to),
-          status: to.completedQuery.statusString,
+          status: to.completedQuery.message,
           time: to.startTime,
         },
       },

extensions/ql-vscode/src/query-history/history-item-label-provider.ts

@@ -77,14 +77,14 @@ export class HistoryItemLabelProvider {
   private getLocalInterpolateReplacements(
     item: LocalQueryInfo,
   ): InterpolateReplacements {
-    const { resultCount = 0, statusString = "in progress" } =
+    const { resultCount = 0, message = "in progress" } =
       item.completedQuery || {};
     return {
       t: item.startTime,
       q: item.getQueryName(),
       d: item.databaseName,
       r: `(${resultCount} results)`,
-      s: statusString,
+      s: message,
       f: item.getQueryFileName(),
       l: this.getLanguageLabel(item),
       "%": "%",

extensions/ql-vscode/src/query-history/query-history-manager.ts

@@ -1058,7 +1058,7 @@ export class QueryHistoryManager extends DisposableObject {
       .map((item) => ({
         label: this.labelProvider.getLabel(item),
         description: item.databaseName,
-        detail: item.completedQuery.statusString,
+        detail: item.completedQuery.message,
         query: item,
       }));
     if (comparableQueryLabels.length < 1) {

extensions/ql-vscode/src/query-results.ts

@@ -75,10 +75,6 @@ export class CompletedQueryInfo implements QueryWithResults {
     this.resultCount = value;
   }
 
-  get statusString(): string {
-    return this.message;
-  }
-
   getResultsPath(selectedTable: string, useSorted = true): string {
     if (!useSorted) {
       return this.query.resultsPaths.resultsPath;