Log errors during query pack discovery

Author: koesie10

extensions/ql-vscode/src/common/discovery.ts

@@ -1,6 +1,6 @@
 import { DisposableObject } from "./disposable-object";
 import { getErrorMessage } from "./helpers-pure";
-import { Logger } from "./logging";
+import { BaseLogger } from "./logging";
 
 /**
  * Base class for "discovery" operations, which scan the file system to find specific kinds of
@@ -13,7 +13,7 @@ export abstract class Discovery extends DisposableObject {
 
   constructor(
     protected readonly name: string,
-    private readonly logger: Logger,
+    protected readonly logger: BaseLogger,
   ) {
     super();
   }

extensions/ql-vscode/src/queries-panel/query-pack-discovery.ts

@@ -5,6 +5,7 @@ import { FALLBACK_QLPACK_FILENAME, QLPACK_FILENAMES } from "../common/ql";
 import { FilePathDiscovery } from "../common/vscode/file-path-discovery";
 import { containsPath } from "../common/files";
 import { getQlPackLanguage } from "../common/qlpack-language";
+import { getErrorMessage } from "../common/helpers-pure";
 
 interface QueryPack {
   path: string;
@@ -70,7 +71,12 @@ export class QueryPackDiscovery extends FilePathDiscovery<QueryPack> {
     let language: QueryLanguage | undefined;
     try {
       language = await getQlPackLanguage(path);
-    } catch (e) {
+    } catch (err) {
+      void this.logger.log(
+        `Query pack discovery failed to determine language for query pack: ${path}\n\tReason: ${getErrorMessage(
+          err,
+        )}`,
+      );
       language = undefined;
     }
     return { path, language };