Skip to content

Commit 2dd841e

Browse files
committed
Pacify lint.
Apparently the linter wants a tsconfig file to be able to lint the compare view typescript. I made the configFile specification in the webpack.config.ts more specific so that we use the same config every time during webview build.
1 parent 609fea4 commit 2dd841e

5 files changed

Lines changed: 33 additions & 10 deletions

File tree

extensions/ql-vscode/gulpfile.js/webpack.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export const config: webpack.Configuration = {
2121
test: /\.(ts|tsx)$/,
2222
loader: 'ts-loader',
2323
options: {
24-
configFile: 'view/tsconfig.json',
24+
configFile: 'src/view/tsconfig.json',
2525
}
2626
},
2727
{

extensions/ql-vscode/src/bqrs-types.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ export interface ResultSetSchema {
6565
* The schema describing the contents of a BQRS file.
6666
*/
6767
export interface ResultSetsSchema {
68-
readonly version: number,
69-
readonly stringPoolSize: number,
70-
readonly resultSets: readonly ResultSetSchema[]
68+
readonly version: number;
69+
readonly stringPoolSize: number;
70+
readonly resultSets: readonly ResultSetSchema[];
7171
}
7272

7373
// See https://help.semmle.com/QL/learn-ql/ql/locations.html for how these are used.

extensions/ql-vscode/src/bqrs-utils.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export function tryGetLocationFromString(
4747
colStart: Number(matches[3]),
4848
lineEnd: Number(matches[4]),
4949
colEnd: Number(matches[5]),
50-
}
50+
};
5151
}
5252
} else {
5353
return undefined;
@@ -56,9 +56,9 @@ export function tryGetLocationFromString(
5656

5757
function isWholeFileMatch(matches: RegExpExecArray): boolean {
5858
return (
59-
matches[2] === "0" &&
60-
matches[3] === "0" &&
61-
matches[4] === "0" &&
62-
matches[5] === "0"
59+
matches[2] === '0' &&
60+
matches[3] === '0' &&
61+
matches[4] === '0' &&
62+
matches[5] === '0'
6363
);
6464
}
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
{
2+
"compilerOptions": {
3+
"module": "esnext",
4+
"moduleResolution": "node",
5+
"target": "es6",
6+
"outDir": "out",
7+
"lib": [
8+
"es6",
9+
"dom"
10+
],
11+
"jsx": "react",
12+
"sourceMap": true,
13+
"rootDir": "..",
14+
"strict": true,
15+
"noUnusedLocals": true,
16+
"noImplicitReturns": true,
17+
"noFallthroughCasesInSwitch": true,
18+
"experimentalDecorators": true
19+
},
20+
"exclude": [
21+
"node_modules"
22+
]
23+
}

extensions/ql-vscode/test/pure-tests/query-test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ describe('using the query server', function() {
206206
await evaluationSucceeded.done();
207207
const info = await cliServer.bqrsInfo(RESULTS_PATH);
208208

209-
for (const resultSet of info["result-sets"]) {
209+
for (const resultSet of info['result-sets']) {
210210
const decoded = await cliServer.bqrsDecode(RESULTS_PATH, resultSet.name);
211211
actualResultSets[resultSet.name] = decoded.tuples;
212212
}

0 commit comments

Comments
 (0)