Skip to content

Commit 2e29d0c

Browse files
committed
Fix incorrect signature reconstruction
1 parent f52ad04 commit 2e29d0c

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

extensions/ql-vscode/src/data-extensions-editor/auto-model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,5 +149,5 @@ function toMethodClassification(modeledMethod: ModeledMethod): Classification {
149149
}
150150

151151
function toFullMethodSignature(method: Method): string {
152-
return `${method.package}.${method.type}.${method.name}${method.signature}`;
152+
return `${method.package}.${method.type}#${method.name}${method.signature}`;
153153
}

extensions/ql-vscode/test/unit-tests/data-extensions-editor/auto-model.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -360,19 +360,19 @@ describe("parsePredictedClassifications", () => {
360360

361361
it("correctly parses the output", () => {
362362
expect(parsePredictedClassifications(predictions)).toEqual({
363-
"org.sql2o.Sql2o.createQuery(String)": {
363+
"org.sql2o.Sql2o#createQuery(String)": {
364364
type: "sink",
365365
kind: "sql injection sink",
366366
input: "Argument[0]",
367367
output: "",
368368
},
369-
"org.sql2o.Sql2o.executeScalar(Class)": {
369+
"org.sql2o.Sql2o#executeScalar(Class)": {
370370
type: "neutral",
371371
kind: "",
372372
input: "",
373373
output: "",
374374
},
375-
"org.sql2o.Sql2o.Sql2o(String,String,String)": {
375+
"org.sql2o.Sql2o#Sql2o(String,String,String)": {
376376
type: "sink",
377377
kind: "sql injection sink",
378378
input: "Argument[1]",

0 commit comments

Comments
 (0)