Skip to content

Commit 2e2ab11

Browse files
authored
Merge pull request #2939 from github/koesie10/unhandled-error-stack
Add stack trace to unhandled error log message
2 parents 246c347 + 22f6ac7 commit 2e2ab11

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

extensions/ql-vscode/src/extension.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1164,13 +1164,16 @@ function addUnhandledRejectionListener() {
11641164
const message = redactableError(
11651165
asError(error),
11661166
)`Unhandled error: ${getErrorMessage(error)}`;
1167+
const stack = getErrorStack(error);
1168+
const fullMessage = stack
1169+
? `Unhandled error: ${stack}`
1170+
: message.fullMessage;
1171+
11671172
// Add a catch so that showAndLogExceptionWithTelemetry fails, we avoid
11681173
// triggering "unhandledRejection" and avoid an infinite loop
1169-
showAndLogExceptionWithTelemetry(
1170-
extLogger,
1171-
telemetryListener,
1172-
message,
1173-
).catch((telemetryError: unknown) => {
1174+
showAndLogExceptionWithTelemetry(extLogger, telemetryListener, message, {
1175+
fullMessage,
1176+
}).catch((telemetryError: unknown) => {
11741177
void extLogger.log(
11751178
`Failed to send error telemetry: ${getErrorMessage(telemetryError)}`,
11761179
);

0 commit comments

Comments
 (0)