Skip to content

Commit 2f9aac9

Browse files
committed
Rename mapping functions to follow same patterns and conventions
1 parent 46ce1cb commit 2f9aac9

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
import { outputJson, readJson } from "fs-extra";
22
import { join } from "path";
33
import { VariantAnalysisRepositoryTask } from "../shared/variant-analysis";
4-
import { mapRepoTaskToData } from "./repo-task-to-data-mapper";
5-
import { mapRepoTaskToDomain } from "./repo-task-to-domain-mapper";
4+
import { mapRepoTaskToDto } from "./repo-task-to-data-mapper";
5+
import { mapRepoTaskToDomainModel } from "./repo-task-to-domain-mapper";
66

77
export const REPO_TASK_FILENAME = "repo_task.json";
88

99
export async function writeRepoTask(
1010
storageDirectory: string,
1111
repoTask: VariantAnalysisRepositoryTask,
1212
): Promise<void> {
13-
const repoTaskData = mapRepoTaskToData(repoTask);
13+
const repoTaskData = mapRepoTaskToDto(repoTask);
1414
await outputJson(join(storageDirectory, REPO_TASK_FILENAME), repoTaskData);
1515
}
1616

@@ -20,5 +20,5 @@ export async function readRepoTask(
2020
const repoTaskData = await readJson(
2121
join(storageDirectory, REPO_TASK_FILENAME),
2222
);
23-
return mapRepoTaskToDomain(repoTaskData);
23+
return mapRepoTaskToDomainModel(repoTaskData);
2424
}

extensions/ql-vscode/src/variant-analysis/repo-tasks-store/repo-task-to-data-mapper.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
VariantAnalysisRepoStatusDto,
99
} from "./repo-tasks-dto";
1010

11-
export function mapRepoTaskToData(
11+
export function mapRepoTaskToDto(
1212
repoTask: VariantAnalysisRepositoryTask,
1313
): VariantAnalysisRepositoryTaskDto {
1414
return {
@@ -17,7 +17,7 @@ export function mapRepoTaskToData(
1717
fullName: repoTask.repository.fullName,
1818
private: repoTask.repository.private,
1919
},
20-
analysisStatus: mapRepoTaskAnalysisStatusToData(repoTask.analysisStatus),
20+
analysisStatus: mapRepoTaskAnalysisStatusToDto(repoTask.analysisStatus),
2121
resultCount: repoTask.resultCount,
2222
artifactSizeInBytes: repoTask.artifactSizeInBytes,
2323
failureMessage: repoTask.failureMessage,
@@ -27,7 +27,7 @@ export function mapRepoTaskToData(
2727
};
2828
}
2929

30-
function mapRepoTaskAnalysisStatusToData(
30+
function mapRepoTaskAnalysisStatusToDto(
3131
analysisStatus: VariantAnalysisRepoStatus,
3232
): VariantAnalysisRepoStatusDto {
3333
switch (analysisStatus) {

extensions/ql-vscode/src/variant-analysis/repo-tasks-store/repo-task-to-domain-mapper.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
VariantAnalysisRepoStatusDto,
99
} from "./repo-tasks-dto";
1010

11-
export function mapRepoTaskToDomain(
11+
export function mapRepoTaskToDomainModel(
1212
repoTask: VariantAnalysisRepositoryTaskDto,
1313
): VariantAnalysisRepositoryTask {
1414
return {
@@ -17,7 +17,9 @@ export function mapRepoTaskToDomain(
1717
fullName: repoTask.repository.fullName,
1818
private: repoTask.repository.private,
1919
},
20-
analysisStatus: mapRepoTaskAnalysisStatusToDomain(repoTask.analysisStatus),
20+
analysisStatus: mapRepoTaskAnalysisStatusToDomainModel(
21+
repoTask.analysisStatus,
22+
),
2123
resultCount: repoTask.resultCount,
2224
artifactSizeInBytes: repoTask.artifactSizeInBytes,
2325
failureMessage: repoTask.failureMessage,
@@ -27,7 +29,7 @@ export function mapRepoTaskToDomain(
2729
};
2830
}
2931

30-
function mapRepoTaskAnalysisStatusToDomain(
32+
function mapRepoTaskAnalysisStatusToDomainModel(
3133
analysisStatus: VariantAnalysisRepoStatusDto,
3234
): VariantAnalysisRepoStatus {
3335
switch (analysisStatus) {

0 commit comments

Comments
 (0)