Remove platform arg as it's never not the process.platform

Author: robertbrignull

extensions/ql-vscode/src/databases/local-databases/database-item-impl.ts

@@ -207,7 +207,6 @@ export class DatabaseItemImpl implements DatabaseItem {
         return pathsEqual(
           databasePath,
           join(testdir, `${testdirbase}.testproj`),
-          process.platform,
         );
       }
     } catch {

extensions/ql-vscode/src/databases/local-databases/database-manager.ts

@@ -652,7 +652,7 @@ export class DatabaseManager extends DisposableObject {
   private isExtensionControlledLocation(uri: vscode.Uri) {
     const storageUri = this.ctx.storageUri || this.ctx.globalStorageUri;
     if (storageUri) {
-      return containsPath(storageUri.fsPath, uri.fsPath, process.platform);
+      return containsPath(storageUri.fsPath, uri.fsPath);
     }
     return false;
   }

extensions/ql-vscode/src/pure/files.ts

@@ -51,37 +51,27 @@ export async function getDirectoryNamesInsidePath(
   return dirNames;
 }
 
-function normalizePath(path: string, platform: NodeJS.Platform): string {
+function normalizePath(path: string): string {
   // On Windows, "C:/", "C:\", and "c:/" are all equivalent. We need
   // to normalize the paths to ensure they all get resolved to the
   // same format. On Windows, we also need to do the comparison
   // case-insensitively.
   path = resolve(path);
-  if (platform === "win32") {
+  if (process.platform === "win32") {
     path = path.toLowerCase();
   }
   return path;
 }
 
-export function pathsEqual(
-  path1: string,
-  path2: string,
-  platform: NodeJS.Platform,
-): boolean {
-  return normalizePath(path1, platform) === normalizePath(path2, platform);
+export function pathsEqual(path1: string, path2: string): boolean {
+  return normalizePath(path1) === normalizePath(path2);
 }
 
 /**
  * Returns true if `parent` contains `child`, or if they are equal.
  */
-export function containsPath(
-  parent: string,
-  child: string,
-  platform: NodeJS.Platform,
-): boolean {
-  return normalizePath(child, platform).startsWith(
-    normalizePath(parent, platform),
-  );
+export function containsPath(parent: string, child: string): boolean {
+  return normalizePath(child).startsWith(normalizePath(parent));
 }
 
 export async function readDirFullPaths(path: string): Promise<string[]> {

extensions/ql-vscode/test/matchers/toEqualPath.ts

@@ -10,7 +10,7 @@ const toEqualPath: MatcherFunction<[expectedPath: unknown]> = function (
     throw new Error("These must be of type string!");
   }
 
-  const pass = pathsEqual(actual, expectedPath, process.platform);
+  const pass = pathsEqual(actual, expectedPath);
   if (pass) {
     return {
       message: () =>

extensions/ql-vscode/test/unit-tests/pure/files.test.ts

@@ -200,7 +200,7 @@ describe("pathsEqual", () => {
         return;
       }
 
-      expect(pathsEqual(path1, path2, platform)).toEqual(expected);
+      expect(pathsEqual(path1, path2)).toEqual(expected);
     },
   );
 });
@@ -295,7 +295,7 @@ describe("containsPath", () => {
         return;
       }
 
-      expect(containsPath(parent, child, platform)).toEqual(expected);
+      expect(containsPath(parent, child)).toEqual(expected);
     },
   );
 });