Skip to content

Commit 303a7d1

Browse files
committed
Show loading icon when downloading repo results
1 parent 7c935b3 commit 303a7d1

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

extensions/ql-vscode/src/stories/variant-analysis/RepoRow.stories.tsx

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ import React from 'react';
33
import { ComponentMeta, ComponentStory } from '@storybook/react';
44

55
import { VariantAnalysisContainer } from '../../view/variant-analysis/VariantAnalysisContainer';
6-
import { VariantAnalysisRepoStatus } from '../../remote-queries/shared/variant-analysis';
6+
import {
7+
VariantAnalysisRepoStatus,
8+
VariantAnalysisScannedRepositoryDownloadStatus,
9+
} from '../../remote-queries/shared/variant-analysis';
710
import { AnalysisAlert, AnalysisRawResults } from '../../remote-queries/shared/analysis-result';
811

912
import analysesResults from '../remote-queries/data/analysesResultsMessage.json';
@@ -62,6 +65,14 @@ Canceled.args = {
6265
status: VariantAnalysisRepoStatus.Canceled,
6366
};
6467

68+
export const SucceededDownloading = Template.bind({});
69+
SucceededDownloading.args = {
70+
...Pending.args,
71+
status: VariantAnalysisRepoStatus.Succeeded,
72+
resultCount: 198,
73+
downloadStatus: VariantAnalysisScannedRepositoryDownloadStatus.InProgress,
74+
};
75+
6576
export const InterpretedResults = Template.bind({});
6677
InterpretedResults.args = {
6778
...Pending.args,

extensions/ql-vscode/src/view/variant-analysis/RepoRow.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ export type RepoRowProps = {
7676
export const RepoRow = ({
7777
repository,
7878
status,
79+
downloadStatus,
7980
resultCount,
8081
interpretedResults,
8182
rawResults,
@@ -104,6 +105,7 @@ export const RepoRow = ({
104105
{status === VariantAnalysisRepoStatus.InProgress && <LoadingIcon label="In progress" />}
105106
{!status && <WarningIcon />}
106107
</span>
108+
{downloadStatus === VariantAnalysisScannedRepositoryDownloadStatus.InProgress && <LoadingIcon label="Downloading" />}
107109
</TitleContainer>
108110
{isExpanded && status &&
109111
<AnalyzedRepoItemContent status={status} interpretedResults={interpretedResults} rawResults={rawResults} />}

0 commit comments

Comments
 (0)