Change createMockVariantAnalysis to receive named params

So that we can set them selectively.

For example, we'd like to set executionStartTime to test sorting by date.

Author: elenatanasoiu

extensions/ql-vscode/src/vscode-tests/factories/remote-queries/shared/variant-analysis.ts

@@ -10,11 +10,17 @@ import { createMockScannedRepos } from './scanned-repositories';
 import { createMockSkippedRepos } from './skipped-repositories';
 import { createMockRepository } from './repository';
 
-export function createMockVariantAnalysis(
-  status: VariantAnalysisStatus = VariantAnalysisStatus.InProgress,
-  scannedRepos: VariantAnalysisScannedRepository[] = createMockScannedRepos(),
-  skippedRepos: VariantAnalysisSkippedRepositories = createMockSkippedRepos()
-): VariantAnalysis {
+export function createMockVariantAnalysis({
+  status = VariantAnalysisStatus.InProgress,
+  scannedRepos = createMockScannedRepos(),
+  skippedRepos = createMockSkippedRepos(),
+  executionStartTime = faker.datatype.number()
+}: {
+  status?: VariantAnalysisStatus,
+  scannedRepos?: VariantAnalysisScannedRepository[],
+  skippedRepos?: VariantAnalysisSkippedRepositories,
+  executionStartTime?: number | undefined
+}): VariantAnalysis {
   const variantAnalysis: VariantAnalysis = {
     id: faker.datatype.number(),
     controllerRepo: {
@@ -32,7 +38,7 @@ export function createMockVariantAnalysis(
     databases: {
       repositories: ['1', '2', '3'],
     },
-    executionStartTime: faker.datatype.number(),
+    executionStartTime,
     createdAt: faker.date.recent().toISOString(),
     updatedAt: faker.date.recent().toISOString(),
     status: status,