Autofix object-shorthand

elenatanasoiu · elenatanasoiu · commit 30cf72b6c839 · 2022-12-01T09:10:46.000Z
diff --git a/extensions/ql-vscode/.eslintrc.js b/extensions/ql-vscode/.eslintrc.js
@@ -66,7 +66,6 @@ module.exports = {
     "no-fallthrough": "off",
     "no-console": "off",
     "no-shadow": "off",
-    "object-shorthand": "off",
     "prefer-template": "off",
     "github/array-foreach": "off",
     "github/no-then": "off",
diff --git a/extensions/ql-vscode/gulpfile.ts/deploy.ts b/extensions/ql-vscode/gulpfile.ts/deploy.ts
@@ -90,7 +90,7 @@ export async function deployPackage(
     await copyPackage(sourcePath, distPath);
 
     return {
-      distPath: distPath,
+      distPath,
       name: packageJson.name,
       version: packageJson.version,
     };
diff --git a/extensions/ql-vscode/src/compare/compare-view.ts b/extensions/ql-vscode/src/compare/compare-view.ts
@@ -88,7 +88,7 @@ export class CompareView extends AbstractWebview<
         },
         columns: fromResultSet.schema.columns,
         commonResultSetNames,
-        currentResultSetName: currentResultSetName,
+        currentResultSetName,
         rows,
         message,
         databaseUri: to.initialInfo.databaseInfo.databaseUri,
diff --git a/extensions/ql-vscode/src/interface.ts b/extensions/ql-vscode/src/interface.ts
@@ -607,7 +607,7 @@ export class ResultsView extends AbstractWebview<
       resultSet: { t: "RawResultSet", ...resultSet },
       numPages: numPagesOfResultSet(resultSet),
       numInterpretedPages: numInterpretedPages(this._interpretation),
-      selectedTable: selectedTable,
+      selectedTable,
       resultSetNames,
     };
 
diff --git a/extensions/ql-vscode/src/log-insights/join-order.ts b/extensions/ql-vscode/src/log-insights/join-order.ts
@@ -360,7 +360,7 @@ class JoinOrderScanner implements EvaluationLogScanner {
     const maxDependentPredicateSize = safeMax(dependentPredicateSizes);
     return {
       maxTupleCount: safeMax(pipelineRun.counts),
-      maxDependentPredicateSize: maxDependentPredicateSize,
+      maxDependentPredicateSize,
     };
   }
 
@@ -491,7 +491,7 @@ class JoinOrderScanner implements EvaluationLogScanner {
         );
       orderTobucket.set(raReference, {
         tupleCounts: newTupleCounts,
-        resultSize: resultSize,
+        resultSize,
         dependentPredicateSizes: newDependentPredicateSizes,
       });
     });
diff --git a/extensions/ql-vscode/src/log-insights/summary-parser.ts b/extensions/ql-vscode/src/log-insights/summary-parser.ts
@@ -111,8 +111,8 @@ async function generateSummarySymbols(
         }
         symbol.iterations[iteration] = {
           startLine: lineNumber,
-          raStartLine: raStartLine,
-          raEndLine: raEndLine,
+          raStartLine,
+          raEndLine,
         };
       }
     }
diff --git a/extensions/ql-vscode/src/remote-queries/gh-api/gh-actions-api-client.ts b/extensions/ql-vscode/src/remote-queries/gh-api/gh-actions-api-client.ts
@@ -83,7 +83,7 @@ export async function getRemoteQueryIndex(
 
     return {
       id: item.id.toString(),
-      artifactId: artifactId,
+      artifactId,
       nwo: item.nwo,
       sha: item.sha,
       resultCount: item.results_count,
diff --git a/extensions/ql-vscode/src/remote-queries/remote-queries-markdown-generation.ts b/extensions/ql-vscode/src/remote-queries/remote-queries-markdown-generation.ts
@@ -67,7 +67,7 @@ export function generateMarkdown(
       resultsFileContent.push(...rawResultTable);
     }
     resultsFiles.push({
-      fileName: fileName,
+      fileName,
       content: resultsFileContent,
     });
   }
@@ -117,7 +117,7 @@ export async function generateVariantAnalysisMarkdown(
       resultsFileContent.push(...rawResultTable);
     }
     resultsFiles.push({
-      fileName: fileName,
+      fileName,
       content: resultsFileContent,
     });
   }
diff --git a/extensions/ql-vscode/src/remote-queries/remote-queries-view.ts b/extensions/ql-vscode/src/remote-queries/remote-queries-view.ts
@@ -106,17 +106,17 @@ export class RemoteQueriesView extends AbstractWebview<
     return {
       queryId: queryResult.queryId,
       queryTitle: query.queryName,
-      queryFileName: queryFileName,
+      queryFileName,
       queryFilePath: query.queryFilePath,
       queryText: query.queryText,
       language: query.language,
       workflowRunUrl: `https://github.com/${query.controllerRepository.owner}/${query.controllerRepository.name}/actions/runs/${query.actionsWorkflowRunId}`,
-      totalRepositoryCount: totalRepositoryCount,
+      totalRepositoryCount,
       affectedRepositoryCount: affectedRepositories.length,
-      totalResultCount: totalResultCount,
+      totalResultCount,
       executionTimestamp: this.formatDate(query.executionStartTime),
-      executionDuration: executionDuration,
-      analysisSummaries: analysisSummaries,
+      executionDuration,
+      analysisSummaries,
       analysisFailures: queryResult.analysisFailures,
     };
   }
diff --git a/extensions/ql-vscode/src/remote-queries/sarif-processing.ts b/extensions/ql-vscode/src/remote-queries/sarif-processing.ts
@@ -75,7 +75,7 @@ function extractResultAlerts(
       severity,
       codeSnippet,
       highlightedRegion,
-      codeFlows: codeFlows,
+      codeFlows,
     };
 
     alerts.push(analysisAlert);
@@ -259,7 +259,7 @@ function getMessage(
         text: messagePart.text,
         location: {
           fileLink: {
-            fileLinkPrefix: fileLinkPrefix,
+            fileLinkPrefix,
             filePath: relatedLocation!.physicalLocation!.artifactLocation!.uri!,
           },
           highlightedRegion: getHighlightedRegion(
diff --git a/extensions/ql-vscode/src/remote-queries/variant-analysis-processor.ts b/extensions/ql-vscode/src/remote-queries/variant-analysis-processor.ts
@@ -77,8 +77,8 @@ export function processUpdatedVariantAnalysis(
     status: processApiStatus(response.status),
     completedAt: response.completed_at,
     actionsWorkflowRunId: response.actions_workflow_run_id,
-    scannedRepos: scannedRepos,
-    skippedRepos: skippedRepos,
+    scannedRepos,
+    skippedRepos,
   };
 
   if (response.failure_reason) {
diff --git a/extensions/ql-vscode/src/run-queries-shared.ts b/extensions/ql-vscode/src/run-queries-shared.ts
@@ -666,7 +666,7 @@ export async function createInitialQueryInfo(
     ...(isQuickEval
       ? {
           queryText: quickEvalText!, // if this query is quick eval, it must have quick eval text
-          quickEvalPosition: quickEvalPosition,
+          quickEvalPosition,
         }
       : {
           queryText: await readFile(queryPath, "utf8"),
diff --git a/extensions/ql-vscode/src/stories/common/CodePaths.stories.tsx b/extensions/ql-vscode/src/stories/common/CodePaths.stories.tsx
@@ -113,7 +113,7 @@ const codeFlows: CodeFlow[] = [
 ];
 
 PowerShell.args = {
-  codeFlows: codeFlows,
+  codeFlows,
   ruleDescription: "ZipSlip vulnerability",
   message: {
     tokens: [
diff --git a/extensions/ql-vscode/src/test-adapter.ts b/extensions/ql-vscode/src/test-adapter.ts
@@ -182,7 +182,7 @@ export class QLTestAdapter extends DisposableObject implements TestAdapter {
     return {
       type: "suite",
       id: testDirectory.path,
-      label: label,
+      label,
       children: QLTestAdapter.createTestOrSuiteInfos(testDirectory.children),
       tooltip: testDirectory.path,
     };
@@ -227,7 +227,7 @@ export class QLTestAdapter extends DisposableObject implements TestAdapter {
 
     this._testStates.fire({
       type: "started",
-      tests: tests,
+      tests,
     } as TestRunStartedEvent);
 
     const currentDatabaseUri =
@@ -357,7 +357,7 @@ export class QLTestAdapter extends DisposableObject implements TestAdapter {
       tests,
       workspacePaths,
       {
-        cancellationToken: cancellationToken,
+        cancellationToken,
         logger: testLogger,
       },
     )) {
diff --git a/extensions/ql-vscode/src/view/results/result-tables.tsx b/extensions/ql-vscode/src/view/results/result-tables.tsx
@@ -168,10 +168,10 @@ export class ResultTables extends React.Component<
       if (resultsPath !== undefined) {
         vscode.postMessage({
           t: "toggleDiagnostics",
-          origResultsPaths: origResultsPaths,
+          origResultsPaths,
           databaseUri: database.databaseUri,
           visible: e.target.checked,
-          metadata: metadata,
+          metadata,
         });
       }
     };
diff --git a/extensions/ql-vscode/src/vscode-tests/factories/extension-context.ts b/extensions/ql-vscode/src/vscode-tests/factories/extension-context.ts
@@ -13,7 +13,7 @@ export function createMockExtensionContext({
   globalStoragePath?: string;
 }): vscode.ExtensionContext {
   return {
-    extensionPath: extensionPath,
+    extensionPath,
     globalStorageUri: vscode.Uri.file(globalStoragePath),
     storageUri: vscode.Uri.file(workspaceStoragePath),
   } as any as vscode.ExtensionContext;
diff --git a/extensions/ql-vscode/src/vscode-tests/factories/remote-queries/gh-api/scanned-repositories.ts b/extensions/ql-vscode/src/vscode-tests/factories/remote-queries/gh-api/scanned-repositories.ts
@@ -13,7 +13,7 @@ export function createMockScannedRepo(
   return {
     repository: {
       ...createMockRepositoryWithMetadata(),
-      name: name,
+      name,
       full_name: "github/" + name,
       private: isPrivate,
     },
diff --git a/extensions/ql-vscode/src/vscode-tests/factories/remote-queries/gh-api/variant-analysis-api-response.ts b/extensions/ql-vscode/src/vscode-tests/factories/remote-queries/gh-api/variant-analysis-api-response.ts
@@ -27,7 +27,7 @@ export function createMockApiResponse(
     query_pack_url: "https://example.com/foo",
     created_at: faker.date.recent().toISOString(),
     updated_at: faker.date.recent().toISOString(),
-    status: status,
+    status,
     actions_workflow_run_id: faker.datatype.number(),
     scanned_repositories: scannedRepos,
     skipped_repositories: skippedRepos,
diff --git a/extensions/ql-vscode/src/vscode-tests/factories/remote-queries/shared/scanned-repositories.ts b/extensions/ql-vscode/src/vscode-tests/factories/remote-queries/shared/scanned-repositories.ts
@@ -16,7 +16,7 @@ export function createMockScannedRepo(
       fullName: "github/" + name,
       private: isPrivate,
     },
-    analysisStatus: analysisStatus,
+    analysisStatus,
     resultCount: faker.datatype.number(),
     artifactSizeInBytes: faker.datatype.number(),
   };
diff --git a/extensions/ql-vscode/src/vscode-tests/factories/remote-queries/shared/variant-analysis.ts b/extensions/ql-vscode/src/vscode-tests/factories/remote-queries/shared/variant-analysis.ts
@@ -43,9 +43,9 @@ export function createMockVariantAnalysis({
     executionStartTime,
     createdAt: faker.date.recent().toISOString(),
     updatedAt: faker.date.recent().toISOString(),
-    status: status,
+    status,
     actionsWorkflowRunId: faker.datatype.number(),
-    scannedRepos: scannedRepos,
-    skippedRepos: skippedRepos,
+    scannedRepos,
+    skippedRepos,
   };
 }
diff --git a/extensions/ql-vscode/src/vscode-tests/factories/remote-queries/variant-analysis-history-item.ts b/extensions/ql-vscode/src/vscode-tests/factories/remote-queries/variant-analysis-history-item.ts
@@ -26,7 +26,7 @@ export function createMockVariantAnalysisHistoryItem({
     completed: false,
     variantAnalysis: createMockVariantAnalysis({
       status: variantAnalysisStatus,
-      executionStartTime: executionStartTime,
+      executionStartTime,
     }),
     userSpecifiedLabel,
   };

Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,8 @@ async function generateSummarySymbols(`
`111`	`111`	`}`
`112`	`112`	`symbol.iterations[iteration] = {`
`113`	`113`	`startLine: lineNumber,`
`114`		`- raStartLine: raStartLine,`
`115`		`- raEndLine: raEndLine,`
	`114`	`+ raStartLine,`
	`115`	`+ raEndLine,`
`116`	`116`	`};`
`117`	`117`	`}`
`118`	`118`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ export function generateMarkdown(`
`67`	`67`	`resultsFileContent.push(...rawResultTable);`
`68`	`68`	`}`
`69`	`69`	`resultsFiles.push({`
`70`		`- fileName: fileName,`
	`70`	`+ fileName,`
`71`	`71`	`content: resultsFileContent,`
`72`	`72`	`});`
`73`	`73`	`}`
`@@ -117,7 +117,7 @@ export async function generateVariantAnalysisMarkdown(`
`117`	`117`	`resultsFileContent.push(...rawResultTable);`
`118`	`118`	`}`
`119`	`119`	`resultsFiles.push({`
`120`		`- fileName: fileName,`
	`120`	`+ fileName,`
`121`	`121`	`content: resultsFileContent,`
`122`	`122`	`});`
`123`	`123`	`}`