Skip to content

Commit 32c44cd

Browse files
committed
Rename Options to AutoModelQueriesOptions
1 parent de5dbea commit 32c44cd

File tree

3 files changed

+26
-19
lines changed

3 files changed

+26
-19
lines changed

extensions/ql-vscode/src/data-extensions-editor/auto-model-codeml-queries.ts

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,6 @@ import { interpretResultsSarif } from "../query-results";
1818
import { join } from "path";
1919
import { assertNever } from "../common/helpers-pure";
2020

21-
type Options = {
22-
cliServer: CodeQLCliServer;
23-
queryRunner: QueryRunner;
24-
databaseItem: DatabaseItem;
25-
queryStorageDir: string;
26-
27-
progress: ProgressCallback;
28-
};
29-
30-
export type AutoModelQueriesResult = {
31-
candidates: Sarif.Log;
32-
};
33-
3421
type AutoModelQueryOptions = {
3522
cliServer: CodeQLCliServer;
3623
queryRunner: QueryRunner;
@@ -158,10 +145,28 @@ async function runAutoModelQuery(
158145
return sarif;
159146
}
160147

161-
export async function runAutoModelQueries(
162-
mode: Mode,
163-
{ cliServer, queryRunner, databaseItem, queryStorageDir, progress }: Options,
164-
): Promise<AutoModelQueriesResult | undefined> {
148+
type AutoModelQueriesOptions = {
149+
mode: Mode;
150+
cliServer: CodeQLCliServer;
151+
queryRunner: QueryRunner;
152+
databaseItem: DatabaseItem;
153+
queryStorageDir: string;
154+
155+
progress: ProgressCallback;
156+
};
157+
158+
export type AutoModelQueriesResult = {
159+
candidates: Sarif.Log;
160+
};
161+
162+
export async function runAutoModelQueries({
163+
mode,
164+
cliServer,
165+
queryRunner,
166+
databaseItem,
167+
queryStorageDir,
168+
progress,
169+
}: AutoModelQueriesOptions): Promise<AutoModelQueriesResult | undefined> {
165170
// maxStep for this part is 1500
166171
const maxStep = 1500;
167172

extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,8 @@ export class DataExtensionsEditorView extends AbstractWebview<
383383
let predictedModeledMethods: Record<string, ModeledMethod>;
384384

385385
if (useLlmGenerationV2()) {
386-
const usages = await runAutoModelQueries(this.mode, {
386+
const usages = await runAutoModelQueries({
387+
mode: this.mode,
387388
cliServer: this.cliServer,
388389
queryRunner: this.queryRunner,
389390
queryStorageDir: this.queryStorageDir,

extensions/ql-vscode/test/vscode-tests/no-workspace/data-extensions-editor/auto-model-codeml-queries.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ describe("runAutoModelQueries", () => {
7373
};
7474

7575
const options = {
76+
mode: Mode.Application,
7677
cliServer: mockedObject<CodeQLCliServer>({
7778
resolveQlpacks: jest.fn().mockResolvedValue({
7879
"/a/b/c/my-extension-pack": {},
@@ -149,7 +150,7 @@ describe("runAutoModelQueries", () => {
149150
progress: jest.fn(),
150151
};
151152

152-
const result = await runAutoModelQueries(Mode.Application, options);
153+
const result = await runAutoModelQueries(options);
153154
expect(result).not.toBeUndefined();
154155

155156
expect(options.cliServer.resolveQlpacks).toHaveBeenCalledTimes(1);

0 commit comments

Comments
 (0)