Skip to content

Commit 36f92da

Browse files
Merge pull request #2664 from github/robertbrignull/ResultTables-naming
Make sure ResultTable and ResultTables are in correctly named files
2 parents 4993e7b + 23a8927 commit 36f92da

File tree

3 files changed

+35
-33
lines changed

3 files changed

+35
-33
lines changed
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
import * as React from "react";
2+
import { AlertTable } from "./alert-table";
3+
import { Graph } from "./graph";
4+
import { RawTable } from "./raw-results-table";
5+
import { ResultTableProps } from "./result-table-utils";
6+
7+
export function ResultTable(props: ResultTableProps) {
8+
const { resultSet } = props;
9+
switch (resultSet.t) {
10+
case "RawResultSet":
11+
return <RawTable {...props} resultSet={resultSet} />;
12+
case "InterpretedResultSet": {
13+
const data = resultSet.interpretation.data;
14+
switch (data.t) {
15+
case "SarifInterpretationData": {
16+
const sarifResultSet = {
17+
...resultSet,
18+
interpretation: { ...resultSet.interpretation, data },
19+
};
20+
return <AlertTable {...props} resultSet={sarifResultSet} />;
21+
}
22+
case "GraphInterpretationData": {
23+
return (
24+
<Graph
25+
graphData={data?.dot[props.offset]}
26+
databaseUri={props.databaseUri}
27+
/>
28+
);
29+
}
30+
}
31+
}
32+
}
33+
}

extensions/ql-vscode/src/view/results/result-tables.tsx renamed to extensions/ql-vscode/src/view/results/ResultTables.tsx

Lines changed: 1 addition & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,7 @@ import {
1414
ParsedResultSets,
1515
IntoResultsViewMsg,
1616
} from "../../common/interface-types";
17-
import { AlertTable } from "./alert-table";
18-
import { Graph } from "./graph";
19-
import { RawTable } from "./raw-results-table";
2017
import {
21-
ResultTableProps,
2218
tableHeaderClassName,
2319
tableHeaderItemClassName,
2420
toggleDiagnosticsClassName,
@@ -28,6 +24,7 @@ import {
2824
import { vscode } from "../vscode-api";
2925
import { sendTelemetry } from "../common/telemetry";
3026
import { basename } from "../../common/path";
27+
import { ResultTable } from "./ResultTable";
3128

3229
/**
3330
* Properties for the `ResultTables` component.
@@ -433,34 +430,6 @@ export class ResultTables extends React.Component<
433430
}
434431
}
435432

436-
function ResultTable(props: ResultTableProps) {
437-
const { resultSet } = props;
438-
switch (resultSet.t) {
439-
case "RawResultSet":
440-
return <RawTable {...props} resultSet={resultSet} />;
441-
case "InterpretedResultSet": {
442-
const data = resultSet.interpretation.data;
443-
switch (data.t) {
444-
case "SarifInterpretationData": {
445-
const sarifResultSet = {
446-
...resultSet,
447-
interpretation: { ...resultSet.interpretation, data },
448-
};
449-
return <AlertTable {...props} resultSet={sarifResultSet} />;
450-
}
451-
case "GraphInterpretationData": {
452-
return (
453-
<Graph
454-
graphData={data?.dot[props.offset]}
455-
databaseUri={props.databaseUri}
456-
/>
457-
);
458-
}
459-
}
460-
}
461-
}
462-
}
463-
464433
function getDefaultResultSet(resultSets: readonly ResultSet[]): string {
465434
return getDefaultResultSetName(
466435
resultSets.map((resultSet) => resultSet.schema.name),

extensions/ql-vscode/src/view/results/results.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
ResultSet,
1616
} from "../../common/interface-types";
1717
import { EventHandlers as EventHandlerList } from "./event-handler-list";
18-
import { ResultTables } from "./result-tables";
18+
import { ResultTables } from "./ResultTables";
1919

2020
import "./resultsView.css";
2121
import { useCallback, useEffect } from "react";

0 commit comments

Comments
 (0)