Split isTheMostRecentlyActivePanel into two methods

Author: robertbrignull

extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts

@@ -99,7 +99,8 @@ export class DataExtensionsEditorView extends AbstractWebview<
     panel.reveal(undefined, true);
 
     panel.onDidChangeViewState(async () => {
-      if (await this.isTheMostRecentlyActivePanel()) {
+      if (panel.active) {
+        await this.onPanelBecameActive();
         await this.updateModelDetailsPanelState(
           this.externalApiUsages,
           this.databaseItem,
@@ -110,15 +111,14 @@ export class DataExtensionsEditorView extends AbstractWebview<
     await this.waitForPanelLoaded();
   }
 
-  private async isTheMostRecentlyActivePanel(): Promise<boolean> {
+  private async onPanelBecameActive(): Promise<void> {
     const panel = await this.getPanel();
+    DataExtensionsEditorView.mostRecentlyActivePanel = panel;
+  }
 
-    if (panel.active) {
-      DataExtensionsEditorView.mostRecentlyActivePanel = panel;
-      return true;
-    } else {
-      return panel === DataExtensionsEditorView.mostRecentlyActivePanel;
-    }
+  private async isTheMostRecentlyActivePanel(): Promise<boolean> {
+    const panel = await this.getPanel();
+    return panel === DataExtensionsEditorView.mostRecentlyActivePanel;
   }
 
   protected async getPanelConfig(): Promise<WebviewPanelConfig> {