You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add better error messages for partial failing variant analysis
Two scenarios handled:
1. no database for existing repo
2. repo does not exits (or no access rights for current user)
In either case, an error message is sent to the logs, with a notificaiton
in a popup.
Copy file name to clipboardExpand all lines: extensions/ql-vscode/src/remote-queries/run-remote-query.ts
+30-4Lines changed: 30 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -33,7 +33,12 @@ export interface QlPack {
33
33
}
34
34
35
35
interfaceQueriesResponse{
36
-
workflow_run_id: number
36
+
workflow_run_id: number,
37
+
errors?: {
38
+
invalid_repositories?: string[],
39
+
repositories_without_database?: string[],
40
+
},
41
+
repositories_queried?: string[],
37
42
}
38
43
39
44
/**
@@ -324,14 +329,35 @@ async function runRemoteQueriesApiRequest(
324
329
data
325
330
}
326
331
);
327
-
constworkflowRunId=response.data.workflow_run_id;
328
-
voidshowAndLogInformationMessage(`Successfully scheduled runs. [Click here to see the progress](https://github.com/${owner}/${repo}/actions/runs/${workflowRunId}).`);
constpopupMessage=`Successfully scheduled runs. [Click here to see the progress](https://github.com/${owner}/${repo}/actions/runs/${response.workflowRunId}).`
342
+
+(response.errors ? '\n\nSome repositories could not be scheduled. See extension log for details.' : '');
343
+
344
+
letlogMessage=`Successfully scheduled runs. See https://github.com/${owner}/${repo}/actions/runs/${response.workflow_run_id}.`;
345
+
if(response.errors){
346
+
logMessage+='\nSome repositories could not be scheduled.';
0 commit comments